smaheshwar-pltr commented on PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3058636169
After some thought, we can maybe narrow down to a few approaches:
- Inspect constructor of subclass; I've implemented this here now
([9edb166](https://github.com/apache/i
smaheshwar-pltr commented on code in PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#discussion_r2198078628
##
pyiceberg/table/__init__.py:
##
@@ -1689,9 +1689,13 @@ def to_pandas(self, **kwargs: Any) -> pd.DataFrame: ...
@abstractmethod
def to_polars
smaheshwar-pltr commented on PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3057977525
> what if we just filter for only the constructor params? wdyt?
Yes, I thought about this and think it's a good idea! We achieve something
similar to that too with @j
smaheshwar-pltr commented on code in PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#discussion_r2198078628
##
pyiceberg/table/__init__.py:
##
@@ -1689,9 +1689,13 @@ def to_pandas(self, **kwargs: Any) -> pd.DataFrame: ...
@abstractmethod
def to_polars
kevinjqliu commented on PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3057713704
interesting! good catch.
I think implicitly the `update` function only allows updating the
constructor parameters. the `cached_property` is a side-effect of using
`self.
smaheshwar-pltr commented on code in PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#discussion_r2197666737
##
pyiceberg/table/__init__.py:
##
@@ -1691,7 +1698,13 @@ def to_polars(self) -> pl.DataFrame: ...
def update(self: S, **overrides: Any) -> S:
smaheshwar-pltr commented on PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3057348447
> Maybe its fine to duplicate the update method in the subclasses and leave
a comment about why its there for the cached properties?
Yeah I think maybe we should just
jayceslesar commented on PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3048675685
Maybe its fine to duplicate the update method in the subclasses and leave a
comment about why its there for the cached properties?
--
This is an automated message from the A
smaheshwar-pltr commented on PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3048178839
> you could add **kwargs in the TableScan constructor too right as a way to
"fix"?
Yes, I think you're right.
I was a bit hesitant to change the constructor, a
jayceslesar commented on PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3046566095
you could add `**kwargs` in the `TableScan` constructor too right as a way
to "fix"? I dont really think there is a good way to deal with this hahahaha
--
This is an automate
smaheshwar-pltr commented on code in PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#discussion_r2190400874
##
pyiceberg/table/__init__.py:
##
@@ -1691,7 +1698,13 @@ def to_polars(self) -> pl.DataFrame: ...
def update(self: S, **overrides: Any) -> S:
smaheshwar-pltr commented on code in PR #2178:
URL: https://github.com/apache/iceberg-python/pull/2178#discussion_r2190397623
##
pyiceberg/table/__init__.py:
##
@@ -1691,7 +1698,13 @@ def to_polars(self) -> pl.DataFrame: ...
def update(self: S, **overrides: Any) -> S:
smaheshwar-pltr opened a new pull request, #2178:
URL: https://github.com/apache/iceberg-python/pull/2178
# Rationale for this change
# Are these changes tested?
# Are there any user-facing changes?
--
This is an automated message from the Apac
13 matches
Mail list logo
