Re: [PR] REST: disallow overriding "credential" in table sessions [iceberg]

2024-07-03 Thread via GitHub
nastra merged PR #10345: URL: https://github.com/apache/iceberg/pull/10345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] REST: disallow overriding "credential" in table sessions [iceberg]

2024-06-04 Thread via GitHub
nastra commented on code in PR #10345: URL: https://github.com/apache/iceberg/pull/10345#discussion_r1625998903 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -915,7 +923,13 @@ private FileIO tableFileIO(SessionContext context, Map config) { }

Re: [PR] REST: disallow overriding "credential" in table sessions [iceberg]

2024-06-04 Thread via GitHub
adutra commented on PR #10345: URL: https://github.com/apache/iceberg/pull/10345#issuecomment-2147204756 @nastra could you have a look at this one as well please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] REST: disallow overriding "credential" in table sessions [iceberg]

2024-05-17 Thread via GitHub
adutra commented on code in PR #10345: URL: https://github.com/apache/iceberg/pull/10345#discussion_r1605267440 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -915,7 +923,13 @@ private FileIO tableFileIO(SessionContext context, Map config) { }

[PR] REST: disallow overriding "credential" in table sessions [iceberg]

2024-05-17 Thread via GitHub
adutra opened a new pull request, #10345: URL: https://github.com/apache/iceberg/pull/10345 See #10256 for context. As requested, this change disallows overriding the `credential` property in table sessions, by introducing an allow-list of auth-related properties that can be overridd