Re: [PR] Procedure to compute table stats [iceberg]

aokolnychyi commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1851007400 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/ComputeTableStatsProcedure.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Procedure to compute table stats [iceberg]

szehon-ho commented on PR #10986: URL: https://github.com/apache/iceberg/pull/10986#issuecomment-2489721338 Looks like all comment addressed, can do a follow up if more. Thanks @karuppayya , and also @aokolnychyi @ajantha-bhat @nastra for addition reviews! -- This is an automated message

Re: [PR] Procedure to compute table stats [iceberg]

szehon-ho merged PR #10986: URL: https://github.com/apache/iceberg/pull/10986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Procedure to compute table stats [iceberg]

aokolnychyi commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1851001612 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/ComputeTableStatsProcedure.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Procedure to compute table stats [iceberg]

aokolnychyi commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1851002127 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/ComputeTableStatsProcedure.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Procedure to compute table stats [iceberg]

aokolnychyi commented on PR #10986: URL: https://github.com/apache/iceberg/pull/10986#issuecomment-2489531213 I'd love to review today as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Procedure to compute table stats [iceberg]

karuppayya commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1850859525 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/SparkProcedures.java: ## @@ -61,6 +61,7 @@ private static Map> initProcedureBuilders() {

Re: [PR] Procedure to compute table stats [iceberg]

karuppayya commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1850858313 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the

Re: [PR] Procedure to compute table stats [iceberg]

ajantha-bhat commented on PR #10986: URL: https://github.com/apache/iceberg/pull/10986#issuecomment-2487663286 > I will take a look at the partition stats PR first by @ajantha-bhat. I want to understand if we want a single analyze procedure or different procedures for table and partition st

Re: [PR] Procedure to compute table stats [iceberg]

ajantha-bhat commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1849657282 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/SparkProcedures.java: ## @@ -61,6 +61,7 @@ private static Map> initProcedureBuilders() {

Re: [PR] Procedure to compute table stats [iceberg]

nastra commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1849603635 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apac

Re: [PR] Procedure to compute table stats [iceberg]

szehon-ho commented on PR #10986: URL: https://github.com/apache/iceberg/pull/10986#issuecomment-2486954110 This looks good to me, will merge tomorrow if no additional comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Procedure to compute table stats [iceberg]

karuppayya commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1849077800 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the

Re: [PR] Procedure to compute table stats [iceberg]

nastra commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1847786178 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apac

Re: [PR] Procedure to compute table stats [iceberg]

karuppayya commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1847343083 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the

Re: [PR] Procedure to compute table stats [iceberg]

karuppayya commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1847344065 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/ComputeTableStatsProcedure.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software

Re: [PR] Procedure to compute table stats [iceberg]

karuppayya commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1847343494 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/ComputeTableStatsProcedure.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software

Re: [PR] Procedure to compute table stats [iceberg]

szehon-ho commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1847292068 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the A

Re: [PR] Procedure to compute table stats [iceberg]

szehon-ho commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1823666819 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/ComputeTableStatsProcedure.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software

Re: [PR] Procedure to compute table stats [iceberg]

karuppayya commented on PR #10986: URL: https://github.com/apache/iceberg/pull/10986#issuecomment-2442283917 @aokolnychyi Can this merged now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Procedure to compute table stats [iceberg]

nastra commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1728365906 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apac

Re: [PR] Procedure to compute table stats [iceberg]

anton-db commented on PR #10986: URL: https://github.com/apache/iceberg/pull/10986#issuecomment-2305511357 I will take a look at the partition stats PR first by @ajantha-bhat. I want to understand if we want a single analyze procedure or different procedures for table and partition stats.

Re: [PR] Procedure to compute table stats [iceberg]

aokolnychyi commented on PR #10986: URL: https://github.com/apache/iceberg/pull/10986#issuecomment-2305512491 I will take a look at the partition stats PR first by @ajantha-bhat. I want to understand if we want a single analyze procedure or different procedures for table and partition stats

Re: [PR] Procedure to compute table stats [iceberg]

nastra commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1727126121 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apac

Re: [PR] Procedure to compute table stats [iceberg]

nastra commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1727128007 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apac

Re: [PR] Procedure to compute table stats [iceberg]

nastra commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1727122550 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apac

Re: [PR] Procedure to compute table stats [iceberg]

nastra commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1727122550 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apac

Re: [PR] Procedure to compute table stats [iceberg]

nastra commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1727121576 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apac

Re: [PR] Procedure to compute table stats [iceberg]

nastra commented on code in PR #10986: URL: https://github.com/apache/iceberg/pull/10986#discussion_r1727119978 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestComputeTableStatsProcedure.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apac

Re: [PR] Procedure to compute table stats [iceberg]

karuppayya commented on PR #10986: URL: https://github.com/apache/iceberg/pull/10986#issuecomment-2303795329 @aokolnychyi @szehon-ho Can you help review this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] Procedure to compute table stats [iceberg]

karuppayya opened a new pull request, #10986: URL: https://github.com/apache/iceberg/pull/10986 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,