Re: [PR] Pass table-token to commit endpoint [iceberg-python]

2024-11-05 Thread via GitHub
Fokko merged PR #1278: URL: https://github.com/apache/iceberg-python/pull/1278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Pass table-token to commit endpoint [iceberg-python]

2024-11-04 Thread via GitHub
kevinjqliu commented on code in PR #1278: URL: https://github.com/apache/iceberg-python/pull/1278#discussion_r1828023718 ## pyiceberg/catalog/rest.py: ## @@ -777,9 +778,15 @@ def commit_table( identifier = self._identifier_to_tuple_without_catalog(table.identifier)

Re: [PR] Pass table-token to commit endpoint [iceberg-python]

2024-11-04 Thread via GitHub
Fokko commented on code in PR #1278: URL: https://github.com/apache/iceberg-python/pull/1278#discussion_r1827782795 ## pyiceberg/catalog/rest.py: ## @@ -777,9 +778,15 @@ def commit_table( identifier = self._identifier_to_tuple_without_catalog(table.identifier)

Re: [PR] Pass table-token to commit endpoint [iceberg-python]

2024-11-01 Thread via GitHub
kevinjqliu commented on code in PR #1278: URL: https://github.com/apache/iceberg-python/pull/1278#discussion_r1826115316 ## pyiceberg/catalog/rest.py: ## @@ -777,9 +778,15 @@ def commit_table( identifier = self._identifier_to_tuple_without_catalog(table.identifier)