Re: [PR] Parquet: Remove duplicate test code [iceberg]

2023-11-02 Thread via GitHub
nastra merged PR #8098: URL: https://github.com/apache/iceberg/pull/8098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Parquet: Remove duplicate test code [iceberg]

2023-11-02 Thread via GitHub
ajantha-bhat commented on code in PR #8098: URL: https://github.com/apache/iceberg/pull/8098#discussion_r1380068898 ## parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java: ## @@ -45,4 +45,20 @@ protected GenericData.Record writeAndRead( return Ite

Re: [PR] Parquet: Remove duplicate test code [iceberg]

2023-11-02 Thread via GitHub
nastra commented on code in PR #8098: URL: https://github.com/apache/iceberg/pull/8098#discussion_r1379909688 ## parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java: ## @@ -45,4 +45,20 @@ protected GenericData.Record writeAndRead( return Iterables

Re: [PR] Parquet: Remove duplicate test code [iceberg]

2023-11-01 Thread via GitHub
ajantha-bhat commented on code in PR #8098: URL: https://github.com/apache/iceberg/pull/8098#discussion_r1379603818 ## parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java: ## @@ -45,4 +45,20 @@ protected GenericData.Record writeAndRead( return Ite

Re: [PR] Parquet: Remove duplicate test code [iceberg]

2023-11-01 Thread via GitHub
ajantha-bhat commented on PR #8098: URL: https://github.com/apache/iceberg/pull/8098#issuecomment-1790077472 @nastra, @Fokko: I have rebased this PR. I think it is good to go. Please check and merge. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Parquet: Remove duplicate test code [iceberg]

2023-11-01 Thread via GitHub
ajantha-bhat commented on code in PR #8098: URL: https://github.com/apache/iceberg/pull/8098#discussion_r1379600584 ## parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java: ## @@ -32,7 +32,7 @@ public class TestParquetReadProjection extends TestReadProje

Re: [PR] Parquet: Remove duplicate test code [iceberg]

2023-11-01 Thread via GitHub
ajantha-bhat commented on code in PR #8098: URL: https://github.com/apache/iceberg/pull/8098#discussion_r1379600138 ## parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java: ## @@ -45,4 +45,20 @@ protected GenericData.Record writeAndRead( return Ite