Re: [PR] Parquet: Internal writer and reader [iceberg]

2025-01-07 Thread via GitHub
rdblue commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1905999633 ## .palantir/revapi.yml: ## @@ -1171,6 +1171,28 @@ acceptedBreaks: \ java.util.function.Function, org.apache.iceberg.io.CloseableIterable,\ \ java.u

Re: [PR] Parquet: Internal writer and reader [iceberg]

2025-01-03 Thread via GitHub
ajantha-bhat closed pull request #11904: Parquet: Internal writer and reader URL: https://github.com/apache/iceberg/pull/11904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Parquet: Internal writer and reader [iceberg]

2025-01-03 Thread via GitHub
ajantha-bhat commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1901971027 ## parquet/src/test/java/org/apache/iceberg/parquet/TestInternalWriter.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Parquet: Internal writer and reader [iceberg]

2025-01-03 Thread via GitHub
ajantha-bhat commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1901970283 ## parquet/src/main/java/org/apache/iceberg/data/parquet/InternalReader.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] Parquet: Internal writer and reader [iceberg]

2025-01-03 Thread via GitHub
ajantha-bhat opened a new pull request, #11904: URL: https://github.com/apache/iceberg/pull/11904 Splitted into 3 commits, a) Refactor BaseParquetWriter to only keep common functionality required for internal and generic writer. b) Refactor BaseParquetReaders to only keep common f