Re: [PR] Parquet,API: Consolidate Parquet's TestHelpers into API module [iceberg]

2024-06-03 Thread via GitHub
advancedxy commented on code in PR #10428: URL: https://github.com/apache/iceberg/pull/10428#discussion_r1624488840 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -173,6 +176,26 @@ public static void assertSameSchemaMap(Map map1, Map

Re: [PR] Parquet,API: Consolidate Parquet's TestHelpers into API module [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10428: URL: https://github.com/apache/iceberg/pull/10428#discussion_r1624384991 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -173,6 +176,26 @@ public static void assertSameSchemaMap(Map map1, Map

Re: [PR] Parquet,API: Consolidate Parquet's TestHelpers into API module [iceberg]

2024-06-02 Thread via GitHub
advancedxy commented on code in PR #10428: URL: https://github.com/apache/iceberg/pull/10428#discussion_r1623856535 ## parquet/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -1,85 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more co