flyrain commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-2641355085
Hi @wgtmac , can we resume this PR? I can help with review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
PaulLiang1 commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-2425321714
Bump comment to keep the bot from closing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-2425314026
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
nastra commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-2248258706
hey @wgtmac sorry for the long wait here but I don't have any spare cycles
atm to review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
wgtmac commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-2248230178
Since this feature has been requested in the community but the PR is not
reviewed for a long time. Do you think this is the right direction here? Or
should I directly support reading arrow
wgtmac commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-2047925627
@nastra Gentle ping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wgtmac commented on code in PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#discussion_r1527198459
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -47,35 +46,45 @@ public VectorizedParquetDefinition
wgtmac commented on code in PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#discussion_r1527197363
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -47,35 +46,45 @@ public VectorizedParquetDefinition
wgtmac commented on code in PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#discussion_r1527197363
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -47,35 +46,45 @@ public VectorizedParquetDefinition
wgtmac commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-164002
Not yet. My rough plan is to do following things:
1. add a new VectorizedValuesReader base class to supporting different
encodings. This is similar to what spark does but reading int
nastra commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-1999811652
> I plan to resolve https://github.com/apache/iceberg/issues/7162 by adding
vectorized readers for all v2 encodings. This is the 1st patch.
@wgtmac do you by any chance have all othe
wgtmac commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-1989767289
@anthonysgro Yes, that is on my radar. I will work on it once v2 encodings
of all primitive types have been supported.
--
This is an automated message from the Apache Git Service.
To res
anthonysgro commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-1989273962
@wgtmac thanks so much for taking this issue on! I am just a user of iceberg
(I have never contributed), but I was curious--is it also possible to include a
resolution for https://git
wgtmac commented on PR #9772:
URL: https://github.com/apache/iceberg/pull/9772#issuecomment-1959648527
I plan to resolve https://github.com/apache/iceberg/issues/7162 by adding
vectorized readers for all v2 encodings. This is the 1st patch. Would you mind
taking a look? @rdblue @nastra @Fok
wgtmac opened a new pull request, #9772:
URL: https://github.com/apache/iceberg/pull/9772
This patch is the preparation work of
https://github.com/apache/iceberg/issues/7162 and it contains following changes:
- Add VectorizedValuesReader interface for future extension.
- Refactor Vecto
15 matches
Mail list logo
