Re: [PR] OpenAPI: Add ContentFile types to spec for scan API [iceberg]

2024-02-27 Thread via GitHub
jackye1995 commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1505122910 ## open-api/rest-catalog-open-api.yaml: ## @@ -3324,6 +3324,281 @@ components: type: integer format: int64 +BooleanTypeValue: + type

Re: [PR] OpenAPI: Add ContentFile types to spec for scan API [iceberg]

2024-02-27 Thread via GitHub
geruh commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1505085892 ## open-api/rest-catalog-open-api.yaml: ## @@ -3324,6 +3324,297 @@ components: type: integer format: int64 +BooleanTypeValue: + type: boo

Re: [PR] OpenAPI: Add ContentFile types to spec for scan API [iceberg]

2024-02-27 Thread via GitHub
rdblue commented on PR #9717: URL: https://github.com/apache/iceberg/pull/9717#issuecomment-1967671600 Mostly looks good to me. I flagged a couple of minor things. Also, I don't think that we resolved this thread: https://github.com/apache/iceberg/pull/9717#discussion_r1501928527 --