Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-07 Thread via GitHub
Fokko commented on code in PR #10434: URL: https://github.com/apache/iceberg/pull/10434#discussion_r1630755533 ## open-api/rest-catalog-open-api.yaml: ## @@ -2597,12 +2598,15 @@ components: assert-last-assigned-partition-id: '#/components/schemas/AssertLastAssignedPa

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-06 Thread via GitHub
flyrain commented on PR #10434: URL: https://github.com/apache/iceberg/pull/10434#issuecomment-2153541117 Thanks @anuragmantri for working on this. Thanks @Fokko for the reivew. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-06 Thread via GitHub
flyrain merged PR #10434: URL: https://github.com/apache/iceberg/pull/10434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-05 Thread via GitHub
flyrain commented on code in PR #10434: URL: https://github.com/apache/iceberg/pull/10434#discussion_r1628249233 ## open-api/rest-catalog-open-api.yaml: ## @@ -2597,12 +2598,15 @@ components: assert-last-assigned-partition-id: '#/components/schemas/AssertLastAssigned

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-05 Thread via GitHub
anuragmantri commented on code in PR #10434: URL: https://github.com/apache/iceberg/pull/10434#discussion_r1628224793 ## open-api/rest-catalog-open-api.yaml: ## @@ -2597,12 +2598,15 @@ components: assert-last-assigned-partition-id: '#/components/schemas/AssertLastAss

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-04 Thread via GitHub
flyrain commented on code in PR #10434: URL: https://github.com/apache/iceberg/pull/10434#discussion_r1626883398 ## open-api/rest-catalog-open-api.yaml: ## @@ -2597,12 +2598,15 @@ components: assert-last-assigned-partition-id: '#/components/schemas/AssertLastAssigned

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-04 Thread via GitHub
flyrain commented on code in PR #10434: URL: https://github.com/apache/iceberg/pull/10434#discussion_r1626883398 ## open-api/rest-catalog-open-api.yaml: ## @@ -2597,12 +2598,15 @@ components: assert-last-assigned-partition-id: '#/components/schemas/AssertLastAssigned

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-04 Thread via GitHub
anuragmantri commented on code in PR #10434: URL: https://github.com/apache/iceberg/pull/10434#discussion_r1626801304 ## open-api/rest-catalog-open-api.py: ## @@ -361,23 +361,29 @@ class RemovePartitionStatisticsUpdate(BaseUpdate): class TableRequirement(BaseModel): -ty