Fokko commented on PR #8798:
URL: https://github.com/apache/iceberg/pull/8798#issuecomment-1770736345
Certainly @ajantha-bhat, thanks for pinging me. Thanks for the PR @nk1506 👍
and @dimas-b for the review
--
This is an automated message from the Apache Git Service.
To respond to the mess
Fokko merged PR #8798:
URL: https://github.com/apache/iceberg/pull/8798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
ajantha-bhat commented on PR #8798:
URL: https://github.com/apache/iceberg/pull/8798#issuecomment-1770707163
can this be merged? @nastra, @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dimas-b commented on code in PR #8798:
URL: https://github.com/apache/iceberg/pull/8798#discussion_r1360635935
##
nessie/src/test/java/org/apache/iceberg/nessie/TestCustomNessieClient.java:
##
@@ -78,30 +77,11 @@ public void testNonExistentCustomClient() {
nk1506 commented on PR #8798:
URL: https://github.com/apache/iceberg/pull/8798#issuecomment-1759595831
> nit: `Adopt` -> `Adapt` in title?
>
> I believe the removed test case is worth keeping.
Since `CONF_NESSIE_CLIENT_BUILDER_IMPL` has been deprecated, replacing it
with `CONF_
