kevinjqliu commented on PR #1817:
URL: https://github.com/apache/iceberg-python/pull/1817#issuecomment-2816813052
now that #1903 is merged, could you rebase this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Fokko commented on PR #1817:
URL: https://github.com/apache/iceberg-python/pull/1817#issuecomment-2813868016
> @Fokko should it be possible to read uncommitted changes?
Yes, it should. If you do a subsequent upsert with the same data, it should
be a no-op. This should be the case toda
koenvo commented on PR #1817:
URL: https://github.com/apache/iceberg-python/pull/1817#issuecomment-2759386009
There is a nice edgecase here..
```python
tbl = catalog.create_table(identifier, schema=schema)
# Define exact schema: required int32 and required string
arrow_sc
mattmartin14 commented on PR #1817:
URL: https://github.com/apache/iceberg-python/pull/1817#issuecomment-2755026682
> Agree! I will work on the test.
>
> With "update" you mean "delete", right?
Hey sorry; just saw this; when i mean update, i mean it invokes an
"overwrite" opera
koenvo commented on PR #1817:
URL: https://github.com/apache/iceberg-python/pull/1817#issuecomment-2745302629
Agree! I will work on the test.
With "update" you mean "delete", right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mattmartin14 commented on PR #1817:
URL: https://github.com/apache/iceberg-python/pull/1817#issuecomment-2745289992
I think since the transaction wrapper has been moved out, there should be a
unit test added to do partial upsert and then throw an error and ensure the
rollback occurs and we
