Xuanwo merged PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
rshkv commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1905520810
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -95,7 +99,17 @@ impl<'a> SnapshotsTable<'a> {
}
/// Scans the snapshots table.
-pub fn scan(&self) -> Res
rshkv commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1905520107
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -95,7 +99,17 @@ impl<'a> SnapshotsTable<'a> {
}
/// Scans the snapshots table.
-pub fn scan(&self) -> Res
Xuanwo commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1905367016
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -95,7 +99,17 @@ impl<'a> SnapshotsTable<'a> {
}
/// Scans the snapshots table.
-pub fn scan(&self) -> Re
rshkv commented on PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#issuecomment-2575057555
@liurenjie1024, rebased.
We don't strictly need this before merging #863. But would be nice to agree
on some stylistic "patterns" for async streams (e.g. using `try_stream!`,
havi
rshkv commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1905316756
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -95,7 +99,17 @@ impl<'a> SnapshotsTable<'a> {
}
/// Scans the snapshots table.
-pub fn scan(&self) -> Res
rshkv commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1905314418
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -95,7 +99,17 @@ impl<'a> SnapshotsTable<'a> {
}
/// Scans the snapshots table.
-pub fn scan(&self) -> Res
rshkv commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1905307332
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -95,7 +99,17 @@ impl<'a> SnapshotsTable<'a> {
}
/// Scans the snapshots table.
-pub fn scan(&self) -> Res
rshkv commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1905304810
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -95,7 +99,17 @@ impl<'a> SnapshotsTable<'a> {
}
/// Scans the snapshots table.
-pub fn scan(&self) -> Res
rshkv commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1905282466
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -95,7 +99,17 @@ impl<'a> SnapshotsTable<'a> {
}
/// Scans the snapshots table.
-pub fn scan(&self) -> Res
Xuanwo commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1905085981
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -95,7 +99,17 @@ impl<'a> SnapshotsTable<'a> {
}
/// Scans the snapshots table.
-pub fn scan(&self) -> Re
liurenjie1024 commented on PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#issuecomment-2574495817
Thanks @rshkv for this pr, exactly what I mean! We should rebase this pr
after #872 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
rshkv commented on code in PR #870:
URL: https://github.com/apache/iceberg-rust/pull/870#discussion_r1901890393
##
crates/iceberg/src/table.rs:
##
@@ -203,7 +203,7 @@ impl Table {
/// Creates a metadata table which provides table-like APIs for inspecting
metadata.
/
rshkv opened a new pull request, #870:
URL: https://github.com/apache/iceberg-rust/pull/870
This changes the metadata table APIs to have `scan()` return streams instead
of a single `RecordBatch`.
Context for this is
https://github.com/apache/iceberg-rust/pull/863#discussion_r19015456
14 matches
Mail list logo
