Re: [PR] Metadata Row Lineage [iceberg]

RussellSpitzer commented on PR #11948: URL: https://github.com/apache/iceberg/pull/11948#issuecomment-2590607674 @nastra Very interested on your thoughts on my test suite here. I'm thinking about how to get away from relying on the Junit4 Test wrapper annotation in TestBase. I know I did so

Re: [PR] Metadata Row Lineage [iceberg]

RussellSpitzer commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1914954813 ## core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1914481119 ## core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Metadata Row Lineage [iceberg]

RussellSpitzer commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913751486 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1468,6 +1510,28 @@ public Builder setPreviousFileLocation(String previousFileLocation) {

Re: [PR] Metadata Row Lineage [iceberg]

RussellSpitzer commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913749663 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1230,6 +1260,18 @@ public Builder addSnapshot(Snapshot snapshot) { snapshotsById.put

Re: [PR] Metadata Row Lineage [iceberg]

RussellSpitzer commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913745405 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1230,6 +1260,18 @@ public Builder addSnapshot(Snapshot snapshot) { snapshotsById.put

Re: [PR] Metadata Row Lineage [iceberg]

RussellSpitzer commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913489410 ## core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Metadata Row Lineage [iceberg]

RussellSpitzer commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913488919 ## core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Metadata Row Lineage [iceberg]

RussellSpitzer commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913485862 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1468,6 +1510,28 @@ public Builder setPreviousFileLocation(String previousFileLocation) {

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912962738 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1468,6 +1510,28 @@ public Builder setPreviousFileLocation(String previousFileLocation) { ret

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912957200 ## core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912956845 ## core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912948011 ## core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java: ## @@ -360,6 +360,8 @@ public void testAddSnapshotToJson() throws IOException { long parent

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912948011 ## core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java: ## @@ -360,6 +360,8 @@ public void testAddSnapshotToJson() throws IOException { long parent

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912936877 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1468,6 +1510,28 @@ public Builder setPreviousFileLocation(String previousFileLocation) { ret

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912935952 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1230,6 +1260,18 @@ public Builder addSnapshot(Snapshot snapshot) { snapshotsById.put(snapshot

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912932707 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1468,6 +1510,28 @@ public Builder setPreviousFileLocation(String previousFileLocation) { ret

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912921265 ## api/src/main/java/org/apache/iceberg/Snapshot.java: ## @@ -171,4 +171,27 @@ default Iterable removedDeleteFiles(FileIO io) { default Integer schemaId() { re

Re: [PR] Metadata Row Lineage [iceberg]

pvary commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912919783 ## api/src/main/java/org/apache/iceberg/Snapshot.java: ## @@ -171,4 +171,27 @@ default Iterable removedDeleteFiles(FileIO io) { default Integer schemaId() { re

[PR] Metadata Row Lineage [iceberg]

RussellSpitzer opened a new pull request, #11948: URL: https://github.com/apache/iceberg/pull/11948 Just the Metadata Changes Required for Row Lineage. Skips out on actual implementation in Manifests and Datafiles but allows for proper creation of Snapshots and Metadata.json with row lineag