Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

nastra merged PR #12017: URL: https://github.com/apache/iceberg/pull/12017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on PR #12017: URL: https://github.com/apache/iceberg/pull/12017#issuecomment-2623514157 Thanks so much for the quick review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on PR #12017: URL: https://github.com/apache/iceberg/pull/12017#issuecomment-2622438741 Sure. Thanks so much for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1934295489 ## docs/docs/view-configuration.md: ## @@ -25,11 +25,12 @@ title: "Configuration" Iceberg views support properties to configure view behavior. Below is an overvie

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

nastra commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1934288600 ## docs/docs/view-configuration.md: ## @@ -25,11 +25,12 @@ title: "Configuration" Iceberg views support properties to configure view behavior. Below is an overview o

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on PR #12017: URL: https://github.com/apache/iceberg/pull/12017#issuecomment-2621506495 @nastra @amogh-jahagirdar Reflected the review by adding tests. Could you review the new changes? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1933677900 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -239,6 +239,36 @@ public void completeCreateView() { assertThat(catalog().viewExists

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1933677900 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -239,6 +239,36 @@ public void completeCreateView() { assertThat(catalog().viewExists

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1933367238 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -239,6 +239,36 @@ public void completeCreateView() { assertThat(catalog().viewExists

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on PR #12017: URL: https://github.com/apache/iceberg/pull/12017#issuecomment-2619657328 Thanks for the review! I'm working on it, and will fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

nastra commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1932469544 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -239,6 +239,36 @@ public void completeCreateView() { assertThat(catalog().viewExists(id

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

nastra commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1932466352 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -239,6 +239,36 @@ public void completeCreateView() { assertThat(catalog().viewExists(id

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

nastra commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1932465818 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -239,6 +239,36 @@ public void completeCreateView() { assertThat(catalog().viewExists(id

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

nastra commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1932458103 ## docs/docs/view-configuration.md: ## @@ -28,6 +28,7 @@ Iceberg views support properties to configure view behavior. Below is an overvie | Property

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on PR #12017: URL: https://github.com/apache/iceberg/pull/12017#issuecomment-2617907358 @nastra I belive you implemented the relevant part. If possible, can I ask you to review this change? -- This is an automated message from the Apache Git Service. To respond to the

[PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue opened a new pull request, #12017: URL: https://github.com/apache/iceberg/pull/12017 Currently, View's metadata file location respects its relevant database location first. If the database doesn't have the location, the View's metadata location is set to a warehouse location.