Re: [PR] Make scope configurable [iceberg-python]

2024-03-04 Thread via GitHub
Fokko commented on PR #484: URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1978135226 Thanks for working on this @himadripal and for the review @flyrain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Make scope configurable [iceberg-python]

2024-03-04 Thread via GitHub
Fokko merged PR #484: URL: https://github.com/apache/iceberg-python/pull/484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Make scope configurable [iceberg-python]

2024-02-29 Thread via GitHub
himadripal commented on PR #484: URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1972533570 locally all passed ```shell (venv) hpal@HPals-MacBook-ProM1 apache-iceberg-python % poetry run pre-commit run --all-files trim trailing whitespace

Re: [PR] Make scope configurable [iceberg-python]

2024-02-29 Thread via GitHub
himadripal commented on PR #484: URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1971983862 > The easiest way is to fix this locally using `make install && make lint` @Fokko Thank you for this tip. -- This is an automated message from the Apache Git Service. To

Re: [PR] Make scope configurable [iceberg-python]

2024-02-29 Thread via GitHub
Fokko commented on PR #484: URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1971916997 The easiest way is to fix this locally using `make install && make lint` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Make scope configurable [iceberg-python]

2024-02-29 Thread via GitHub
himadripal commented on PR #484: URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1971852828 @Fokko Thank you for the approval. Fixed the conflict, can you please let the build checks run? -- This is an automated message from the Apache Git Service. To respond to the m