Re: [PR] Make connect compatable with kafka plugin.discovery [iceberg]

2024-10-16 Thread via GitHub
bryanck merged PR #10536: URL: https://github.com/apache/iceberg/pull/10536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Make connect compatable with kafka plugin.discovery [iceberg]

2024-10-16 Thread via GitHub
bryanck commented on PR #10536: URL: https://github.com/apache/iceberg/pull/10536#issuecomment-2417541790 Thanks for the PR @joswlv and sorry for the delay in the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Make connect compatable with kafka plugin.discovery [iceberg]

2024-09-01 Thread via GitHub
joswlv commented on PR #10536: URL: https://github.com/apache/iceberg/pull/10536#issuecomment-2323305709 @ismailsimsek Thanks for the nice comment. added linesense to the file, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Make connect compatable with kafka plugin.discovery [iceberg]

2024-09-01 Thread via GitHub
ismailsimsek commented on PR #10536: URL: https://github.com/apache/iceberg/pull/10536#issuecomment-2323285840 +1 , @joswlv i believe you need to add license header to the file? [example here](https://github.com/apache/iceberg/blob/main/flink/v1.20/flink/src/main/resources/META-INF/services

[PR] Make connect compatable with kafka plugin.discovery [iceberg]

2024-06-21 Thread via GitHub
joswlv opened a new pull request, #10536: URL: https://github.com/apache/iceberg/pull/10536 What is [Plugin Discovery](https://kafka.apache.org/documentation.html#connect_plugindiscovery). When connector is used with kafka version above 3.6 with default plugin.discovery worker config