Re: [PR] Introduce AuthManager [iceberg-python]

2025-04-14 Thread via GitHub
sungwy merged PR #1908: URL: https://github.com/apache/iceberg-python/pull/1908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Introduce AuthManager [iceberg-python]

2025-04-14 Thread via GitHub
corleyma commented on code in PR #1908: URL: https://github.com/apache/iceberg-python/pull/1908#discussion_r2043086971 ## pyiceberg/catalog/rest/auth.py: ## @@ -0,0 +1,81 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Introduce AuthManager [iceberg-python]

2025-04-14 Thread via GitHub
Fokko commented on code in PR #1908: URL: https://github.com/apache/iceberg-python/pull/1908#discussion_r2042820333 ## pyiceberg/catalog/rest/auth.py: ## @@ -0,0 +1,81 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] Introduce AuthManager [iceberg-python]

2025-04-13 Thread via GitHub
sungwy commented on code in PR #1908: URL: https://github.com/apache/iceberg-python/pull/1908#discussion_r2041146404 ## dev/Dockerfile: ## @@ -52,7 +52,7 @@ RUN curl --retry 5 -s https://repository.apache.org/content/groups/snapshots/org # Download AWS bundle -RUN curl --r

[PR] Introduce AuthManager [iceberg-python]

2025-04-13 Thread via GitHub
sungwy opened a new pull request, #1908: URL: https://github.com/apache/iceberg-python/pull/1908 # Rationale for this change https://github.com/apache/iceberg-python/issues/1906 # Are these changes tested? Yes, unit tested # Are there any user-facing ch