Re: [PR] Include DELETE entries when inspecting [iceberg-python]

2025-02-28 Thread via GitHub
kevinjqliu commented on PR #1731: URL: https://github.com/apache/iceberg-python/pull/1731#issuecomment-2691394793 oops youre right. definitely not needed in `_files`. For `partitions`, looks like we dont need the deleted files either. nit: perhaps we can make it explicit by setting `disc

Re: [PR] Include DELETE entries when inspecting [iceberg-python]

2025-02-27 Thread via GitHub
Fokko commented on PR #1731: URL: https://github.com/apache/iceberg-python/pull/1731#issuecomment-2689012943 > I think we should make the same change to the _files, not so sure about partitions That's funny, was thinking the other way around. For `_files` it lists all the files of th

[PR] Include DELETE entries when inspecting [iceberg-python]

2025-02-27 Thread via GitHub
Fokko opened a new pull request, #1731: URL: https://github.com/apache/iceberg-python/pull/1731 While doing some checks, I've noticed that these are missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov