syun64 commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1474460001
##
tests/catalog/test_base.py:
##
@@ -355,8 +162,6 @@ def test_create_table_pyarrow_schema(catalog:
InMemoryCatalog, pyarrow_schema_si
table = catalog.create_
Fokko commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1474126225
##
tests/catalog/test_base.py:
##
@@ -355,8 +162,6 @@ def test_create_table_pyarrow_schema(catalog:
InMemoryCatalog, pyarrow_schema_si
table = catalog.create_t
syun64 commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1473049416
##
tests/catalog/test_base.py:
##
@@ -355,8 +162,6 @@ def test_create_table_pyarrow_schema(catalog:
InMemoryCatalog, pyarrow_schema_si
table = catalog.create_
syun64 commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1472905954
##
tests/catalog/test_base.py:
##
@@ -355,8 +162,6 @@ def test_create_table_pyarrow_schema(catalog:
InMemoryCatalog, pyarrow_schema_si
table = catalog.create_
syun64 commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1471609730
##
tests/catalog/test_base.py:
##
Review Comment:
Makes sense @kevinjqliu💯
--
This is an automated message from the Apache Git Service.
To respond to the
kevinjqliu commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1471604886
##
tests/catalog/test_base.py:
##
Review Comment:
thanks for the review @syun64. Since the In-Memory catalog is not a
"production" catalog, I'm inclined t
syun64 commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1471348272
##
tests/catalog/test_base.py:
##
Review Comment:
This is a _super-nit_ (please feel free to take it or leave it): should we
rename this test module to **test
kevinjqliu commented on PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#issuecomment-1916109508
> Should we also add this catalog to the tests in
tests/integration/test_reads.py?
@Fokko I had the same idea! Unfortunately, the way integration tests are
configured right
kevinjqliu commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1470604775
##
pyiceberg/catalog/in_memory.py:
##
@@ -0,0 +1,222 @@
+import uuid
+from typing import (
+Dict,
+List,
+Optional,
+Set,
+Union,
+)
+
+from
Fokko commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1469989182
##
pyiceberg/catalog/__init__.py:
##
@@ -137,12 +138,19 @@ def load_sql(name: str, conf: Properties) -> Catalog:
raise NotInstalledError("SQLAlchemy support
kevinjqliu commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1462219314
##
tests/catalog/test_base.py:
##
@@ -572,6 +379,11 @@ def test_commit_table(catalog: InMemoryCatalog) -> None:
NestedField(4, "add", LongType()),
Fokko commented on PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#issuecomment-1903442816
Thanks for working on this @kevinjqliu. The issues was created a long time
ago, before we had the SqlCatalog with sqlite support. Sqlite can also work [in
memory](https://www.sqlite.or
HonahX commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1461380205
##
pyiceberg/table/__init__.py:
##
@@ -504,6 +504,12 @@ def _(update: AddSchemaUpdate, base_metadata:
TableMetadata, context: _TableMeta
if update.last_column
HonahX commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1461380205
##
pyiceberg/table/__init__.py:
##
@@ -504,6 +504,12 @@ def _(update: AddSchemaUpdate, base_metadata:
TableMetadata, context: _TableMeta
if update.last_column
HonahX commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1461380205
##
pyiceberg/table/__init__.py:
##
@@ -504,6 +504,12 @@ def _(update: AddSchemaUpdate, base_metadata:
TableMetadata, context: _TableMeta
if update.last_column
kevinjqliu commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1461359249
##
tests/catalog/test_base.py:
##
@@ -585,8 +397,10 @@ def test_commit_table(catalog: InMemoryCatalog) -> None:
# Then
assert response.metadata.tabl
kevinjqliu commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1461251541
##
tests/catalog/test_base.py:
##
@@ -16,243 +16,41 @@
# under the License.
# pylint:disable=redefined-outer-name
-from typing import (
-Dict,
-Lis
kevinjqliu commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1461251110
##
pyiceberg/catalog/in_memory.py:
##
@@ -0,0 +1,222 @@
+import uuid
+from typing import (
+Dict,
+List,
+Optional,
+Set,
+Union,
+)
+
+from
kevinjqliu commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1461250937
##
pyiceberg/catalog/in_memory.py:
##
@@ -0,0 +1,222 @@
+import uuid
+from typing import (
+Dict,
+List,
+Optional,
+Set,
+Union,
+)
+
+from
19 matches
Mail list logo
