Fokko merged PR #352:
URL: https://github.com/apache/iceberg-python/pull/352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on PR #352:
URL: https://github.com/apache/iceberg-python/pull/352#issuecomment-1927962033
@HonahX Thanks 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
HonahX commented on code in PR #352:
URL: https://github.com/apache/iceberg-python/pull/352#discussion_r1477438386
##
pyiceberg/table/__init__.py:
##
@@ -133,6 +132,41 @@
_JAVA_LONG_MAX = 9223372036854775807
+def _check_schema(table_schema: Schema, other_schema: "pa.Schema"
Fokko commented on code in PR #352:
URL: https://github.com/apache/iceberg-python/pull/352#discussion_r1475910255
##
pyiceberg/table/__init__.py:
##
@@ -133,6 +132,43 @@
_JAVA_LONG_MAX = 9223372036854775807
+def _check_schema(table_schema: Schema, other_schema: "pa.Schema")
Fokko commented on code in PR #352:
URL: https://github.com/apache/iceberg-python/pull/352#discussion_r1475909693
##
pyiceberg/schema.py:
##
@@ -221,6 +227,11 @@ def find_type(self, name_or_id: Union[str, int],
case_sensitive: bool = True) ->
def highest_field_id(self) ->
HonahX commented on code in PR #352:
URL: https://github.com/apache/iceberg-python/pull/352#discussion_r1475415226
##
pyiceberg/schema.py:
##
@@ -221,6 +227,11 @@ def find_type(self, name_or_id: Union[str, int],
case_sensitive: bool = True) ->
def highest_field_id(self) ->
HonahX commented on code in PR #352:
URL: https://github.com/apache/iceberg-python/pull/352#discussion_r1475415226
##
pyiceberg/schema.py:
##
@@ -221,6 +227,11 @@ def find_type(self, name_or_id: Union[str, int],
case_sensitive: bool = True) ->
def highest_field_id(self) ->
