kevinjqliu commented on PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#issuecomment-2549620946
Thanks for the contribution, @AhmedNader42 !
I created #1439 so that we can add more integration tests for the REST
catalog.
I also started this [devlist
discussion](http
kevinjqliu merged PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
Fokko commented on code in PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#discussion_r1889169039
##
tests/integration/test_rest_catalog.py:
##
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
kevinjqliu commented on PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#issuecomment-2549530592
@AhmedNader42 looks like the RAT check failed. For new files, we need to
include the ASF license on top, like
https://github.com/apache/iceberg-python/blob/ceffe08ad90a0d150c6f1
AhmedNader42 commented on PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#issuecomment-2549362930
I created a new file for REST Catalog integration tests
`tests/integration/test_rest_catalog.py` as suggestsed by @kevinjqliu and
included some tests covering the `namespace_e
AhmedNader42 commented on PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#issuecomment-2547750984
Hello @sungwy, Thank you for pointing that out! Sounds good to me. I'll work
on adding some test cases for REST Catalog in test_reads.py
> Hi @AhmedNader42 - thank you
sungwy commented on PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#issuecomment-2546756342
Hi @AhmedNader42 - thank you very much for picking up this issue and getting
a working solution up already!
I'm in agreement with @kevinjqliu 's comment, that it would be grea
AhmedNader42 commented on code in PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#discussion_r1887246806
##
tests/catalog/test_rest.py:
##
@@ -681,6 +681,51 @@ def test_update_namespace_properties_200(rest_mock:
Mocker) -> None:
assert response == Propert
kevinjqliu commented on code in PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#discussion_r1887152140
##
tests/catalog/test_rest.py:
##
@@ -681,6 +681,51 @@ def test_update_namespace_properties_200(rest_mock:
Mocker) -> None:
assert response == Propertie
AhmedNader42 opened a new pull request, #1434:
URL: https://github.com/apache/iceberg-python/pull/1434
I have added the namespace_exists functionality for REST Catalog.
Here's an example usage similar to the table_exists function of the same
class
