chil-pavn closed pull request #240: Implemented Remaining Catalog operations
for REST catalog
URL: https://github.com/apache/iceberg-go/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chil-pavn commented on PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#issuecomment-2592240873
hey @zeroshade i am closing this pull request as i don't think it is any
more relevant. Will open a new PR for the unit tests.
--
This is an automated message from the Apache Git Ser
zeroshade commented on PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#issuecomment-2578303311
Ideally we should definitely be doing that, I'll definitely admit to my own
mistakes in not doing so lately. :(
--
This is an automated message from the Apache Git Service.
To respon
chil-pavn commented on PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#issuecomment-2578201718
@zeroshade Sure, I will take that up. Also, it would be very helpful if i we
link PRs to the respected issues.
--
This is an automated message from the Apache Git Service.
To respond
zeroshade commented on PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#issuecomment-2578191104
@chil-pavn that would be fantastic thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chil-pavn commented on PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#issuecomment-2578183988
Hey @zeroshade , it appears there was already PR #146 for the same table
operations, which also got merged. Should i work on the unit tests, as i could
see that was not included in the
zeroshade commented on code in PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#discussion_r1902041491
##
catalog/rest.go:
##
@@ -710,3 +777,54 @@ func (r *RestCatalog) UpdateNamespaceProperties(ctx
context.Context, namespace t
return doPost[payload, Properti
zeroshade commented on code in PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#discussion_r1902040341
##
catalog/rest.go:
##
@@ -626,11 +628,76 @@ func (r *RestCatalog) LoadTable(ctx context.Context,
identifier table.Identifier
}
func (r *RestCatalog) DropTable(
chil-pavn commented on code in PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#discussion_r1901421555
##
catalog/rest.go:
##
@@ -710,3 +777,54 @@ func (r *RestCatalog) UpdateNamespaceProperties(ctx
context.Context, namespace t
return doPost[payload, Properti
chil-pavn commented on code in PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#discussion_r1901420358
##
catalog/rest.go:
##
@@ -626,11 +628,76 @@ func (r *RestCatalog) LoadTable(ctx context.Context,
identifier table.Identifier
}
func (r *RestCatalog) DropTable(
chil-pavn commented on code in PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#discussion_r1901416497
##
README.md:
##
@@ -1,38 +1,3 @@
-
-
-# Iceberg Golang
-
-[](https://pkg.go.dev/github.co
zeroshade commented on code in PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#discussion_r1901207365
##
README.md:
##
@@ -1,38 +1,3 @@
-
-
-# Iceberg Golang
-
-[](https://pkg.go.dev/github.co
piyushsingariya commented on code in PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#discussion_r1899655889
##
catalog/rest.go:
##
@@ -710,3 +777,54 @@ func (r *RestCatalog) UpdateNamespaceProperties(ctx
context.Context, namespace t
return doPost[payload, Pr
zeroshade commented on PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#issuecomment-2565678980
@chil-pavn In general this is looking good, I'll give it a more in-depth
review in the next couple days. Could you add some unit tests for these as we
have for the other functions? (ba
14 matches
Mail list logo
