Re: [PR] Implementation of version metadata table for view [iceberg]

huan233usc commented on PR #12014: URL: https://github.com/apache/iceberg/pull/12014#issuecomment-2658363474 Thank you both for the review, will update this pr accordingly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Implementation of version metadata table for view [iceberg]

danielcweeks commented on PR #12014: URL: https://github.com/apache/iceberg/pull/12014#issuecomment-2637830139 I feel like structurally we're not approaching this the right way. We already have a `BaseMetadataTable` implementation used for metadata tables. View metadata is a table and we

Re: [PR] Implementation of version metadata table for view [iceberg]

danielcweeks commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1943535003 ## core/src/main/java/org/apache/iceberg/BaseViewMetadataTable.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Implementation of version metadata table for view [iceberg]

danielcweeks commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1943527210 ## core/src/main/java/org/apache/iceberg/BaseViewMetadataTable.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Implementation of version metadata table for view [iceberg]

danielcweeks commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1943526207 ## core/src/main/java/org/apache/iceberg/BaseViewMetadataTable.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Implementation of version metadata table for view [iceberg]

danielcweeks commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1943525552 ## core/src/main/java/org/apache/iceberg/BaseViewMetadataTable.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Implementation of version metadata table for view [iceberg]

danielcweeks commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1943508673 ## core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java: ## @@ -67,6 +71,31 @@ public View loadView(TableIdentifier identifier) { throw

Re: [PR] Implementation of version metadata table for view [iceberg]

danielcweeks commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1943506895 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -462,6 +463,26 @@ private LoadTableResponse loadInternal( @Override public T

Re: [PR] Implementation of version metadata table for view [iceberg]

danielcweeks commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1943504087 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -462,6 +463,26 @@ private LoadTableResponse loadInternal( @Override public T

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942423409 ## core/src/main/java/org/apache/iceberg/ViewMetadataReadTask.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942422055 ## core/src/main/java/org/apache/iceberg/ViewMetadataReadTask.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942420149 ## core/src/main/java/org/apache/iceberg/ViewVersionTable.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942418799 ## core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java: ## @@ -67,6 +71,31 @@ public View loadView(TableIdentifier identifier) { throw new No

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942414224 ## core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java: ## @@ -67,6 +71,31 @@ public View loadView(TableIdentifier identifier) { throw new No

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942411767 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -462,6 +463,26 @@ private LoadTableResponse loadInternal( @Override public Table l

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942406385 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -2109,6 +2109,34 @@ public void createViewWithCustomMetadataLoca

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942405817 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -2109,6 +2109,34 @@ public void createViewWithCustomMetadataLoca

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942402976 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -2109,6 +2109,34 @@ public void createViewWithCustomMetadataLoca

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942401950 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1639,6 +1641,29 @@ public void updateViewLocationConflict() { .hasMessageContainin

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942400841 ## core/src/test/java/org/apache/iceberg/view/TestViews.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942399432 ## core/src/test/java/org/apache/iceberg/view/TestViews.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942399911 ## core/src/test/java/org/apache/iceberg/view/TestViews.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942398588 ## core/src/test/java/org/apache/iceberg/view/TestViews.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942397562 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java: ## @@ -1730,6 +1732,16 @@ public void testPositionDeletesManyColumns() { assertThat(scanTas

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942398142 ## core/src/test/java/org/apache/iceberg/view/TestViews.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r1942374605 ## core/src/main/java/org/apache/iceberg/BaseViewMetadataTable.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Implementation of version metadata table for view [iceberg]

huan233usc commented on PR #12014: URL: https://github.com/apache/iceberg/pull/12014#issuecomment-2634887332 merge conflicts resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on PR #12014: URL: https://github.com/apache/iceberg/pull/12014#issuecomment-2634170184 @huan233usc could you resolve the merge conflicts please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Implementation of version metadata table for view [iceberg]

nastra commented on PR #12014: URL: https://github.com/apache/iceberg/pull/12014#issuecomment-2626675921 @huan233usc sorry for the delay here. I'll try to review this either today or early next week -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Implementation of version metadata table for view [iceberg]

huan233usc commented on PR #12014: URL: https://github.com/apache/iceberg/pull/12014#issuecomment-2622776393 Hi, @amogh-jahagirdar @nastra Could I get some feedback for this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Implementation of version metadata table for view [iceberg]

huan233usc opened a new pull request, #12014: URL: https://github.com/apache/iceberg/pull/12014 This PR implements the .version metadata mentioned in https://github.com/apache/iceberg/issues/9844 Added integration tests and tested locally using rest catalog https://github.com/user-