Re: [PR] Implement Sorted Writes [iceberg-python]

2024-07-06 Thread via GitHub
vinjai commented on code in PR #871: URL: https://github.com/apache/iceberg-python/pull/871#discussion_r1667347220 ## pyiceberg/utils/arrow_sorting.py: ## @@ -0,0 +1,110 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Implement Sorted Writes [iceberg-python]

2024-07-06 Thread via GitHub
vinjai commented on code in PR #871: URL: https://github.com/apache/iceberg-python/pull/871#discussion_r1667347220 ## pyiceberg/utils/arrow_sorting.py: ## @@ -0,0 +1,110 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Implement Sorted Writes [iceberg-python]

2024-07-04 Thread via GitHub
vinjai commented on PR #871: URL: https://github.com/apache/iceberg-python/pull/871#issuecomment-2209659177 This PR solves for: 1. Writing sorted datasets to a partitioned or non-partitioned iceberg table. 2. Generating manifests with correct sort-order-id. 3. Integration tests to ma

Re: [PR] Implement Sorted Writes [iceberg-python]

2024-07-04 Thread via GitHub
vinjai commented on PR #871: URL: https://github.com/apache/iceberg-python/pull/871#issuecomment-2209659324 @Fokko This PR is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to