zeroshade commented on PR #111:
URL: https://github.com/apache/iceberg-go/pull/111#issuecomment-2545965423
closing in favor of #176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
zeroshade closed pull request #111: IO Implementation using Go CDK
URL: https://github.com/apache/iceberg-go/pull/111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
zeroshade merged PR #176:
URL: https://github.com/apache/iceberg-go/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
dwilson1988 commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2542660861
@zeroshade - I'll take a look this weekend!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2542428675
LGTM 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
zeroshade commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2542436725
@dwilson1988 When you get a chance, can you take a look at the changes I
made here. I liked your thought on isolating things, but there was still a
bunch of specific options for partic
zeroshade commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2542399559
@loicalleyne following pyiceberg's example, I've added an option to force
virtual addressing. That work for you?
--
This is an automated message from the Apache Git Service.
To respo
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2542287393
Is it intended to not provide the choice between virtual hosted bucket
addressing and path-style addressing?
LGTM otherwise - the tests are passing :)
--
This is an automated m
zeroshade commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2542213486
@loicalleyne can you take a look at the latest changes I made here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2541868880
[s3.UsePathStyle](https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/s3#Options.UsePathStyle
)
```
// Allows you to enable the client to use path-style addressing, i.e.,
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2541810573
My understanding is that it's just another property to pass in `props`.
Would also have to add it as a recognized property/constant in io/s3.go I
should think.
--
This is an auto
zeroshade commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2541769470
@loicalleyne I haven't dug too far into the blob code, is it a relatively
easy fix to handle that `s3ForcePathStyle`?
--
This is an automated message from the Apache Git Service.
To
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2540225753
Then I suspect it might be the `s3ForcePathStyle` option referred to
[here](https://github.com/google/go-cloud/issues/3472). It affected Minio in
particular once they moved to s3 V2
zeroshade commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2540196113
I've been able to replicate and debug the issue myself locally. Aside from
needing to make a bunch of changes to fix the prefix, bucket and key strings, I
was still unable to get goclo
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2540021664
I did some debugging by copying some of the test scenarios into a regular Go
program (if anyone can tell me how to run Delve in VsCode on a test that uses
testify please let me know)
zeroshade commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2539692409
@loicalleyne looks like the integration tests are failing, unable to read
the manifest files from the minio instance.
--
This is an automated message from the Apache Git Service.
To
dwilson1988 commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2539362190
@loicalleyne - you should just be able to manually remove conflicts in
`go.mod`, delete `go.sum` and run a `go mod tidy`. Probably best to do this
after syncing your fork and rebasin
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2539346597
@zeroshade
> In the meantime can you resolve the conflict in the go.mod? Thanks!
I tried updating the `go.mod` version and toolchain versions to match `main`
and ran `go mod ti
zeroshade commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2537284504
I should be able to give this a review tomorrow or Friday. In the meantime
can you resolve the conflict in the go.mod? Thanks!
--
This is an automated message from the Apache Git Ser
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2537210180
@zeroshade hoping you can review when you've got time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dwilson1988 commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2510407143
> Hi @dwilson1988, do you think you'll have time to take a look at this?
I opened a PR on your branch earlier today
--
This is an automated message from the Apache Git Servi
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2510372691
Hi @dwilson1988, do you think you'll have time to take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dwilson1988 commented on code in PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#discussion_r1865055118
##
io/blob.go:
##
@@ -0,0 +1,311 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
dwilson1988 commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2479414127
> @dwilson1988 made the suggested changes, there's a deprecation warning on
the S3 config EndpointResolver methods that I haven't had time to look into,
maybe you could take a look?
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2477543077
@dwilson1988 made the suggested changes, there's a deprecation warning on
the S3 config EndpointResolver methods that I haven't had time to look into,
maybe you could take a look?
loicalleyne commented on code in PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#discussion_r1842965194
##
io/blob.go:
##
@@ -0,0 +1,311 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
loicalleyne commented on code in PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#discussion_r1842949566
##
io/blob.go:
##
@@ -0,0 +1,311 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
dwilson1988 commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2473977368
Cool - just checking. I'll be patient. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2471667064
hi @dwilson1988
yes, I'm wrapping up some work on another project and will be jumping back
on this in a day or two.
--
This is an automated message from the Apache Git Service.
dwilson1988 commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2470837211
@loicalleyne is this still on your radar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
zeroshade commented on code in PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#discussion_r1811073199
##
io/gcs.go:
##
@@ -0,0 +1,63 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+//
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2420559048
@dwilson1988
Sounds good, I've made the changes, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dwilson1988 commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2418127366
Okay, played around a bit and here's where my head is at.
The main reason I'd like to isolated the creation of a `*blob.Bucket` is
I've found that the particular implementation
dwilson1988 commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2418063681
Understood! I'll dig into your last question and get back to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2418061193
My goal today was just to "get something on paper" to move this forward
since the other PR has been stalled since July, I used the other PR as a
starting point so I mostly followed t
dwilson1988 commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2418039810
@loicalleyne - happy to take a look. We use this internally in some of our
software with Parquet and implemented a ReaderAt. I'll do a more thorough
review when I get a chance, but
loicalleyne commented on PR #176:
URL: https://github.com/apache/iceberg-go/pull/176#issuecomment-2418031722
@dwilson1988 I saw your note about wanting to work on the CDK features, if
you're able to provide some feedback that would be great.
--
This is an automated message from the Apache
loicalleyne opened a new pull request, #176:
URL: https://github.com/apache/iceberg-go/pull/176
Extends PR [#111](https://github.com/apache/iceberg-go/pull/111)
Implements [#92](https://github.com/apache/iceberg-go/issues/92). The Go CDK
has well-maintained implementations for accessi
loicalleyne closed pull request #175: IO Implementation using Go CDK
URL: https://github.com/apache/iceberg-go/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
loicalleyne opened a new pull request, #175:
URL: https://github.com/apache/iceberg-go/pull/175
This PR extends PR [#111](https://github.com/apache/iceberg-go/pull/111)
Implements [#92](https://github.com/apache/iceberg-go/issues/92). The Go CDK
has well-maintained implementations for
srilman opened a new pull request, #111:
URL: https://github.com/apache/iceberg-go/pull/111
Partially implements #92. The Go CDK has well-maintained implementations for
accessing objects stores from S3, Azure, and GCS via a `io/fs.Fs`-like
interface. However, their file interface doesn't su
41 matches
Mail list logo
