Re: [PR] Hive metastore register table [iceberg-python]

2025-02-03 Thread via GitHub
Fokko merged PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Hive metastore register table [iceberg-python]

2025-01-30 Thread via GitHub
JoniKet commented on code in PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1935585281 ## tests/integration/test_register_table.py: ## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

Re: [PR] Hive metastore register table [iceberg-python]

2025-01-30 Thread via GitHub
Fokko commented on code in PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1935484216 ## tests/integration/test_register_table.py: ## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agre

Re: [PR] Hive metastore register table [iceberg-python]

2025-01-30 Thread via GitHub
Fokko commented on code in PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1935484216 ## tests/integration/test_register_table.py: ## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agre

Re: [PR] Hive metastore register table [iceberg-python]

2025-01-29 Thread via GitHub
JoniKet commented on code in PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1933478098 ## tests/catalog/test_hive.py: ## @@ -204,6 +204,87 @@ def test_check_number_of_namespaces(table_schema_simple: Schema) -> None: catalog.create_table("

Re: [PR] Hive metastore register table [iceberg-python]

2025-01-28 Thread via GitHub
kevinjqliu commented on code in PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1932434496 ## pyiceberg/catalog/hive.py: ## @@ -404,7 +404,22 @@ def register_table(self, identifier: Union[str, Identifier], metadata_location: Raises:

Re: [PR] Hive metastore register table [iceberg-python]

2025-01-28 Thread via GitHub
Fokko commented on code in PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1932207978 ## tests/catalog/test_hive.py: ## @@ -204,6 +204,87 @@ def test_check_number_of_namespaces(table_schema_simple: Schema) -> None: catalog.create_table("ta

Re: [PR] Hive metastore register table [iceberg-python]

2025-01-28 Thread via GitHub
JoniKet commented on code in PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1931766744 ## pyiceberg/catalog/hive.py: ## @@ -404,7 +404,22 @@ def register_table(self, identifier: Union[str, Identifier], metadata_location: Raises:

Re: [PR] Hive metastore register table [iceberg-python]

2025-01-27 Thread via GitHub
Fokko commented on code in PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1931152082 ## pyiceberg/catalog/hive.py: ## @@ -404,7 +404,22 @@ def register_table(self, identifier: Union[str, Identifier], metadata_location: Raises:

Re: [PR] Hive metastore register table [iceberg-python]

2025-01-27 Thread via GitHub
kevinjqliu commented on code in PR #1580: URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1930765272 ## pyiceberg/catalog/hive.py: ## @@ -404,7 +404,22 @@ def register_table(self, identifier: Union[str, Identifier], metadata_location: Raises:

[PR] Hive metastore register table [iceberg-python]

2025-01-27 Thread via GitHub
JoniKet opened a new pull request, #1580: URL: https://github.com/apache/iceberg-python/pull/1580 Added the register_table operation for Hive metastore. Had use case where there were existing tables in AWS S3, which needed to be registered to Hive metastore. Registering table with PyIceberg