nk1506 commented on PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#issuecomment-1825492456
Thanks @pvary for suggesting and reviewing this. I will start rebasing View
[PR](https://github.com/apache/iceberg/pull/8907).
--
This is an automated message from the Apache Git Servic
pvary commented on PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#issuecomment-1825177267
Thanks for all the work and patience @nk1506 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pvary merged PR #9011:
URL: https://github.com/apache/iceberg/pull/9011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1403960661
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
meta
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1403606978
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
met
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1403245669
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
meta
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1402866684
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
met
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1402866684
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
met
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1401876287
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
meta
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1401665955
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
met
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1400329609
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
meta
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1400329609
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
meta
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1396283697
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1396122380
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
pvary commented on PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#issuecomment-1814715417
I have one question left, which is somewhat related to the new usage of the
`HiveOperationsBase`
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1395930004
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1391553311
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1391550697
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -156,7 +147,7 @@ protected void doRefresh() {
String metadataLocation = null
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1389355915
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -156,7 +147,7 @@ protected void doRefresh() {
String metadataLocation = null;
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1389352401
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1389343659
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1389343294
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1389343659
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1389341091
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1389340756
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1389339429
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1389307575
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
27 matches
Mail list logo
