tomtongue commented on PR #10684:
URL: https://github.com/apache/iceberg/pull/10684#issuecomment-2242396006
Thanks for the review! Will submit a backport PR, then the Flink migration
will be complete.
--
This is an automated message from the Apache Git Service.
To respond to the message,
nastra merged PR #10684:
URL: https://github.com/apache/iceberg/pull/10684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
tomtongue commented on code in PR #10684:
URL: https://github.com/apache/iceberg/pull/10684#discussion_r1686114970
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestCompressionSettings.java:
##
@@ -91,19 +94,36 @@ public void testCompressionAvro() throws Excep
tomtongue commented on code in PR #10684:
URL: https://github.com/apache/iceberg/pull/10684#discussion_r1686114529
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestCompressionSettings.java:
##
@@ -91,19 +94,36 @@ public void testCompressionAvro() throws Excep
nastra commented on code in PR #10684:
URL: https://github.com/apache/iceberg/pull/10684#discussion_r1686000869
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestCompressionSettings.java:
##
@@ -91,19 +94,36 @@ public void testCompressionAvro() throws Exceptio
nastra commented on code in PR #10684:
URL: https://github.com/apache/iceberg/pull/10684#discussion_r1686000131
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestCompressionSettings.java:
##
@@ -91,19 +94,36 @@ public void testCompressionAvro() throws Exceptio
tomtongue commented on PR #10684:
URL: https://github.com/apache/iceberg/pull/10684#issuecomment-2241892402
@nastra Added all the remaining classes and removed
`getSourceTableExtension` and `getSinkTableExtension`. Could you review the
changes?
--
This is an automated message from the Ap
