Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-11-04 Thread via GitHub
pvary commented on PR #11144: URL: https://github.com/apache/iceberg/pull/11144#issuecomment-2454809299 Merged to main. Thanks for the review @stevenzwu, @rodmeneses and @netvl! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-11-04 Thread via GitHub
pvary merged PR #11144: URL: https://github.com/apache/iceberg/pull/11144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-10-24 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1816081581 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-10-24 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1815365314 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-10-24 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1814746167 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-10-24 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1814725764 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java: ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-10-24 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1814677509 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java: ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-10-24 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1814675000 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-10-24 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1814669250 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-10-23 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1813326096 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777853976 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
rodmeneses commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r165276 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
rodmeneses commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r163032 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
rodmeneses commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r162669 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
rodmeneses commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r144352 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
rodmeneses commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r144788 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
rodmeneses commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r142164 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on PR #11144: URL: https://github.com/apache/iceberg/pull/11144#issuecomment-2377941746 @rodmeneses: If you have time, I would like to ask you to review the PR. Thanks, Peter -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on PR #11144: URL: https://github.com/apache/iceberg/pull/11144#issuecomment-2377940857 @netvl: I'm struggling to find the relevant comment (there are too many of them already), but I would like to ask you to check if the proposed `MaintenanceTaskBuilder` would serve your ne

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r132933 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r132933 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r131546 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r131032 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestExpireSnapshots.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r130668 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777436962 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777677656 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777664609 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DeleteFilesProcessor.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777629218 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777664609 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DeleteFilesProcessor.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777615921 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DeleteFilesProcessor.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777650877 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777650877 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777636984 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/ExpireSnapshotsProcessor.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777498534 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java: ## @@ -0,0 +1,333 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777494503 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/ExpireSnapshotsProcessor.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777478245 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777422424 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestExpireSnapshots.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777436962 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777019687 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DeleteFilesProcessor.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777019356 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777017806 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestExpireSnapshotsProcessor.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache S

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777014142 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/ExpireSnapshots.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777011823 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1777011390 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/ExpireSnapshots.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1776790554 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestExpireSnapshots.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1776795255 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestMaintenanceE2E.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1776788013 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestExpireSnapshots.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1776785546 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DeleteFilesProcessor.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1776740970 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-26 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1776729546 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/ExpireSnapshotsProcessor.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1776132332 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DeleteFilesProcessor.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1776099559 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestExpireSnapshotsProcessor.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apac

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1776031911 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/ScheduledBuilderTestBase.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r177578 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1775726921 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1775726921 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1775706927 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/ExpireSnapshots.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1775689568 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/ExpireSnapshotsProcessor.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1775673258 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1775665663 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/ExpireSnapshots.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-25 Thread via GitHub
netvl commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1775653554 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765733792 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/ExpireSnapshots.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765719946 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestTableMaintenance.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765720264 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestTableMaintenance.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765703804 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/ExpireSnapshotsProcessor.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765701035 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/AsyncDeleteFiles.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765707969 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/ExpireSnapshots.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765700118 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/TableMaintenance.java: ## @@ -0,0 +1,356 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765697595 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/ExpireSnapshots.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765541651 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/ExpireSnapshotsProcessor.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765542690 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestAsyncDeleteFiles.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765532417 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765524254 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestTableMaintenance.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765524051 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestTableMaintenance.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765523637 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestTableMaintenance.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765522216 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestTableMaintenance.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765522579 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestTableMaintenance.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
stevenzwu commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765317845 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765390022 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestTableMaintenance.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765388661 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestTableMaintenance.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765381953 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/ScheduledBuilderTestBase.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765381575 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestExpireSnapshots.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765379043 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/TestExpireSnapshots.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765378601 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/stream/ScheduledBuilderTestBase.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765376976 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockRemover.java: ## @@ -135,15 +135,16 @@ void testMetrics() throws Exception {

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765373981 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestExpireSnapshotsProcessor.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache S

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765368195 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestAsyncDeleteFiles.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765361114 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestAsyncDeleteFiles.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765360492 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestAsyncDeleteFiles.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765357904 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestAsyncDeleteFiles.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765355573 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/TableMaintenance.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765355202 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestAsyncDeleteFiles.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765351302 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestAsyncDeleteFiles.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765348075 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/TableMaintenance.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765343352 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/TableMaintenance.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765343124 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/TableMaintenance.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765340442 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/TableMaintenance.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765341352 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/TableMaintenance.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765340100 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TableManager + ExpireSnapshots [iceberg]

2024-09-18 Thread via GitHub
pvary commented on code in PR #11144: URL: https://github.com/apache/iceberg/pull/11144#discussion_r1765337465 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/stream/MaintenanceTaskBuilder.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

  1   2   >