Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-28 Thread via GitHub
pvary commented on PR #9139: URL: https://github.com/apache/iceberg/pull/9139#issuecomment-1830829590 Merged with specific PRs for the different parts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-28 Thread via GitHub
pvary closed pull request #9139: Flink: Backport #8553 to v1.15, v1.16 URL: https://github.com/apache/iceberg/pull/9139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-28 Thread via GitHub
pvary commented on PR #9145: URL: https://github.com/apache/iceberg/pull/9145#issuecomment-1830828255 Merged to main. Thanks @stevenzwu for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-28 Thread via GitHub
pvary merged PR #9145: URL: https://github.com/apache/iceberg/pull/9145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-27 Thread via GitHub
pvary commented on PR #9139: URL: https://github.com/apache/iceberg/pull/9139#issuecomment-1827525105 > @pvary I meant separate to multiple back port PRs. one PR for one purpose. it is easier to review too. Thanks! -- This is an automated message from the Apache Git Service. To res

Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-24 Thread via GitHub
stevenzwu commented on PR #9139: URL: https://github.com/apache/iceberg/pull/9139#issuecomment-1826002055 @pvary I meant separate to multiple back port PRs. one PR for one purpose. it is easier to review too. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-24 Thread via GitHub
pvary commented on PR #9139: URL: https://github.com/apache/iceberg/pull/9139#issuecomment-1825349863 > @pvary can you separate this out as a separate PR? > > Fix backport differences for #8852 (#8877, #8880) TBH, I do not really understand your comment here 😞 To decrease

Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-23 Thread via GitHub
stevenzwu commented on PR #9139: URL: https://github.com/apache/iceberg/pull/9139#issuecomment-1824802554 @pvary can you separate this out as a separate PR? Fix backport differences for https://github.com/apache/iceberg/pull/8852 (https://github.com/apache/iceberg/pull/8877, https://

Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-23 Thread via GitHub
pvary commented on PR #9139: URL: https://github.com/apache/iceberg/pull/9139#issuecomment-1824501764 CC: @nastra, @nk1506 - When backporting changes, please make sure that all of the changes as similar as possible. After fixing the backport differences caused by previous backports I