Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-11-27 Thread via GitHub
arkadius commented on PR #11244: URL: https://github.com/apache/iceberg/pull/11244#issuecomment-2503682790 > @arkadius: Could you please backport the change to the relevant older Flink branches? Sure, here it is: #11665 -- This is an automated message from the Apache Git Service.

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-11-25 Thread via GitHub
pvary commented on PR #11244: URL: https://github.com/apache/iceberg/pull/11244#issuecomment-2497876484 @arkadius: Could you please backport the change to the relevant older Flink branches? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-11-25 Thread via GitHub
pvary commented on PR #11244: URL: https://github.com/apache/iceberg/pull/11244#issuecomment-2497874666 Thanks for the PR @arkadius and @rodmeneses for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-11-25 Thread via GitHub
pvary merged PR #11244: URL: https://github.com/apache/iceberg/pull/11244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-11-21 Thread via GitHub
arkadius commented on PR #11244: URL: https://github.com/apache/iceberg/pull/11244#issuecomment-2491435175 > @arkadius: Could you please make sure the tests are run? Just change the commit message of the last commit and force push the branch, or something? Sure, I rebased the branch t

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-11-21 Thread via GitHub
pvary commented on PR #11244: URL: https://github.com/apache/iceberg/pull/11244#issuecomment-2491241065 We definitely need this. @arkadius: Could you please make sure the tests are run? Just change the commit message of the last commit and force push the branch, or something? -- This i

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-11-20 Thread via GitHub
arkadius commented on PR #11244: URL: https://github.com/apache/iceberg/pull/11244#issuecomment-2490187518 I think that this option would benefit this project in a good transitional migration to the new interface in Table API / Flink SQL. What is the alternative plan for the migration betwe

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-11-20 Thread via GitHub
rodmeneses commented on PR #11244: URL: https://github.com/apache/iceberg/pull/11244#issuecomment-2489891920 Hi @arkadius is this still needed/relevant ? please advise, as it will be closed due to inactivity soon cc @pvary -- This is an automated message from the Apache Git Service. T

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-11-20 Thread via GitHub
github-actions[bot] commented on PR #11244: URL: https://github.com/apache/iceberg/pull/11244#issuecomment-2489805105 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-10-21 Thread via GitHub
arkadius commented on PR #11244: URL: https://github.com/apache/iceberg/pull/11244#issuecomment-2425998578 @rodmeneses @pvary I've done all fixes that were discussed in comments. Can we move forward with this change? Do we need more eyes to take a look at the docs part? @stevenzwu can you t

Re: [PR] Flink: Add table.exec.iceberg.use-v2-sink option [iceberg]

2024-10-10 Thread via GitHub
arkadius commented on code in PR #11244: URL: https://github.com/apache/iceberg/pull/11244#discussion_r1795763231 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/TestFlinkTableSinkExtended.java: ## @@ -165,18 +210,25 @@ public void testWriteParallelism() {