Re: [PR] Fix verification script, `verify_rc.sh` [iceberg-go]

2024-11-13 Thread via GitHub
Fokko merged PR #199: URL: https://github.com/apache/iceberg-go/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Fix verification script, `verify_rc.sh` [iceberg-go]

2024-11-12 Thread via GitHub
kevinjqliu commented on PR #199: URL: https://github.com/apache/iceberg-go/pull/199#issuecomment-2471457974 @Fokko do you mind taking a look? this fixes the verification script. Would be good to have merged for the new RC -- This is an automated message from the Apache Git Service. To re

Re: [PR] Fix verification script, `verify_rc.sh` [iceberg-go]

2024-11-12 Thread via GitHub
kevinjqliu commented on PR #199: URL: https://github.com/apache/iceberg-go/pull/199#issuecomment-2471312299 verified change by running `dev/release/verify_rc.sh 0.1.0 0` ``` + VERIFY_SUCCESS=yes + echo 'RC looks good!' RC looks good! ``` -- This is an automated message