Re: [PR] Fix retrying logic [iceberg-python]

2024-02-29 Thread via GitHub
HonahX merged PR #480: URL: https://github.com/apache/iceberg-python/pull/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Fix retrying logic [iceberg-python]

2024-02-28 Thread via GitHub
anupam-saini commented on code in PR #480: URL: https://github.com/apache/iceberg-python/pull/480#discussion_r1506787323 ## tests/catalog/test_rest.py: ## @@ -306,24 +306,39 @@ def test_list_namespace_with_parent_200(rest_mock: Mocker) -> None: ] -def test_list_namespa

Re: [PR] Fix retrying logic [iceberg-python]

2024-02-28 Thread via GitHub
Fokko commented on PR #480: URL: https://github.com/apache/iceberg-python/pull/480#issuecomment-1970033106 cc @anupam-saini -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix retrying logic [iceberg-python]

2024-02-28 Thread via GitHub
Fokko commented on code in PR #480: URL: https://github.com/apache/iceberg-python/pull/480#discussion_r1506750317 ## tests/catalog/test_rest.py: ## @@ -306,24 +306,39 @@ def test_list_namespace_with_parent_200(rest_mock: Mocker) -> None: ] -def test_list_namespaces_419

[PR] Fix retrying logic [iceberg-python]

2024-02-28 Thread via GitHub
Fokko opened a new pull request, #480: URL: https://github.com/apache/iceberg-python/pull/480 It was refreshing on each of the calls. I think the `before_sleep` is the correct hook. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi