Re: [PR] Fix environment variable parsing [iceberg-python]

2024-02-14 Thread via GitHub
Fokko merged PR #423: URL: https://github.com/apache/iceberg-python/pull/423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Fix environment variable parsing [iceberg-python]

2024-02-13 Thread via GitHub
hussein-awala commented on code in PR #423: URL: https://github.com/apache/iceberg-python/pull/423#discussion_r1488694863 ## tests/utils/test_config.py: ## @@ -41,6 +41,11 @@ def test_from_environment_variables_uppercase() -> None: assert Config().get_catalog_config("PRODUC

Re: [PR] Fix environment variable parsing [iceberg-python]

2024-02-13 Thread via GitHub
hussein-awala commented on code in PR #423: URL: https://github.com/apache/iceberg-python/pull/423#discussion_r1488694863 ## tests/utils/test_config.py: ## @@ -41,6 +41,11 @@ def test_from_environment_variables_uppercase() -> None: assert Config().get_catalog_config("PRODUC

[PR] Fix environment variable parsing [iceberg-python]

2024-02-13 Thread via GitHub
Fokko opened a new pull request, #423: URL: https://github.com/apache/iceberg-python/pull/423 ```bash export PYICEBERG_CATALOG__SOMETHING__S3__REGION=eu-north-1 ``` Before: ```python >>> from pyiceberg.catalog import load_catalog >>> load_catalog('something').propert