Re: [PR] Fix `version` and `rc` in `rc.yml` [iceberg-go]

2024-11-13 Thread via GitHub
RussellSpitzer merged PR #202: URL: https://github.com/apache/iceberg-go/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ice

Re: [PR] Fix `version` and `rc` in `rc.yml` [iceberg-go]

2024-11-13 Thread via GitHub
RussellSpitzer commented on PR #202: URL: https://github.com/apache/iceberg-go/pull/202#issuecomment-2474842101 Thanks @kevinjqliu for the PR and @zeroshade for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Fix `version` and `rc` in `rc.yml` [iceberg-go]

2024-11-13 Thread via GitHub
kevinjqliu commented on code in PR #202: URL: https://github.com/apache/iceberg-go/pull/202#discussion_r1841065941 ## .github/workflows/rc.yml: ## @@ -42,17 +42,25 @@ jobs: - name: Prepare for tag if: github.ref_type == 'tag' run: | - version=${

[PR] Fix `version` and `rc` in `rc.yml` [iceberg-go]

2024-11-13 Thread via GitHub
kevinjqliu opened a new pull request, #202: URL: https://github.com/apache/iceberg-go/pull/202 Follow up to #199. For the RC workflow running on a tag, there was an issue resulting in the wrong filename used for the `tar.gz` file, for example, `apache-iceberg-go-0.1.0-rc1-rc1.tar.gz`. No