[PR] Feature/otf 1500 column comparison [iceberg]

2024-09-17 Thread via GitHub
jenbaldwin opened a new pull request, #11152: URL: https://github.com/apache/iceberg/pull/11152 Draft PR for early feedback. (btw otf-1500 is internal jira number) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Feature/otf 1500 column comparison [iceberg]

2024-08-15 Thread via GitHub
jenbaldwin closed pull request #10941: Feature/otf 1500 column comparison URL: https://github.com/apache/iceberg/pull/10941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Feature/otf 1500 column comparison [iceberg]

2024-08-15 Thread via GitHub
jenbaldwin commented on PR #10941: URL: https://github.com/apache/iceberg/pull/10941#issuecomment-2291796147 didn't intend to open draft PR to main, wip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Feature/otf 1500 column comparison [iceberg]

2024-08-15 Thread via GitHub
nastra commented on PR #10941: URL: https://github.com/apache/iceberg/pull/10941#issuecomment-2291079599 @jenbaldwin could you please add some context to the problem that this PR is trying to solve? Also what does OTF-1500 stand for? -- This is an automated message from the Apache Git Ser

Re: [PR] Feature/otf 1500 column comparison [iceberg]

2024-08-15 Thread via GitHub
jenbaldwin commented on code in PR #10941: URL: https://github.com/apache/iceberg/pull/10941#discussion_r1718072083 ## core/src/main/java/org/apache/iceberg/BaseEntriesTable.java: ## @@ -217,6 +237,11 @@ public Boolean eq(BoundReference ref, Literal lit) { return ROWS

Re: [PR] Feature/otf 1500 column comparison [iceberg]

2024-08-15 Thread via GitHub
jenbaldwin commented on code in PR #10941: URL: https://github.com/apache/iceberg/pull/10941#discussion_r1718071718 ## api/src/main/java/org/apache/iceberg/expressions/BoundTermPredicate.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Feature/otf 1500 column comparison [iceberg]

2024-08-15 Thread via GitHub
jenbaldwin commented on code in PR #10941: URL: https://github.com/apache/iceberg/pull/10941#discussion_r1718071308 ## api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java: ## @@ -218,6 +218,11 @@ public Boolean lt(BoundReference ref, Literal lit) {

[PR] Feature/otf 1500 column comparison [iceberg]

2024-08-14 Thread via GitHub
jenbaldwin opened a new pull request, #10941: URL: https://github.com/apache/iceberg/pull/10941 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,