Re: [PR] Feat: replace sort order [iceberg-python]

mwa28 commented on PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#issuecomment-3049337981 Hello, any update on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#issuecomment-2890131022 > Hey @JasperHG90 sorry for the late reply, the notification got buried in my mailbox. I'll definitely review this, it would be great to get this in 👍 No apology necessary

Re: [PR] Feat: replace sort order [iceberg-python]

Fokko commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r2093695075 ## pyiceberg/table/__init__.py: ## @@ -1113,6 +1128,14 @@ def update_schema(self, allow_incompatible_changes: bool = False, case_sensitive name_mappi

Re: [PR] Feat: replace sort order [iceberg-python]

Fokko commented on PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#issuecomment-2887701178 Hey @JasperHG90 sorry for the late reply, the notification got buried in my mailbox. I'll definitely review this, it would be great to get this in 👍 -- This is an automated messag

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#issuecomment-2804191139 @kevinjqliu @Fokko do either one of you have time to review this PR in the coming weeks? I have some time on my hands and I’d love to wrap this PR up! Thanks in advance -- Th

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r2009213055 ## pyiceberg/table/update/sorting.py: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r2010982962 ## pyiceberg/table/update/sorting.py: ## @@ -0,0 +1,136 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r2010973601 ## pyiceberg/table/update/sorting.py: ## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r2010973423 ## pyiceberg/table/update/sorting.py: ## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r2010982138 ## pyiceberg/table/update/sorting.py: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1958426255 ## mkdocs/docs/api.md: ## @@ -1194,6 +1194,24 @@ with table.update_spec() as update: update.rename_field("bucketed_id", "sharded_id") ``` +## Sort ord

Re: [PR] Feat: replace sort order [iceberg-python]

Fokko commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1958406030 ## mkdocs/docs/api.md: ## @@ -1194,6 +1194,24 @@ with table.update_spec() as update: update.rename_field("bucketed_id", "sharded_id") ``` +## Sort order up

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1957932193 ## tests/integration/test_sort_order_update.py: ## @@ -0,0 +1,109 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lice

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#issuecomment-2662539581 > Hey @JasperHG90 apologies for the delay, ive been tied up with some other stuff. > > I've compared the current implementation with java's implementation and it seems li

Re: [PR] Feat: replace sort order [iceberg-python]

kevinjqliu commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1957416511 ## pyiceberg/table/update/sorting.py: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#issuecomment-2661465739 > This looks great @JasperHG90 Sorry for the late review, it slipped through on my mailbox. > > Could you also add a few docs: https://github.com/apache/iceberg-python/bl

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1957337471 ## tests/integration/test_sort_order_update.py: ## @@ -0,0 +1,109 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lice

Re: [PR] Feat: replace sort order [iceberg-python]

JasperHG90 commented on PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#issuecomment-2661456796 No problem @Fokko . Thanks for your comments and your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Feat: replace sort order [iceberg-python]

Fokko commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1949036376 ## pyiceberg/table/update/sorting.py: ## @@ -0,0 +1,115 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.