github-actions[bot] closed pull request #11165: FIX: Exception Handling in AWS
Glue renameTable Method
URL: https://github.com/apache/iceberg/pull/11165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on PR #11165:
URL: https://github.com/apache/iceberg/pull/11165#issuecomment-2489804888
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on PR #11165:
URL: https://github.com/apache/iceberg/pull/11165#issuecomment-2475084200
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
amogh-jahagirdar commented on PR #11165:
URL: https://github.com/apache/iceberg/pull/11165#issuecomment-2366931136
Thanks @singhpk234!
At the moment the [catalog API for
renameTable](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/catalog/Catalog.java#
singhpk234 commented on PR #11165:
URL: https://github.com/apache/iceberg/pull/11165#issuecomment-2366902023
The particular case referred here makes sense but was thinking if this is
something we need to handle broadly ?
IMHO we are lacking the exception handling entirely here for ex:
amogh-jahagirdar commented on code in PR #11165:
URL: https://github.com/apache/iceberg/pull/11165#discussion_r1770604602
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##
@@ -415,15 +415,19 @@ public void renameTable(TableIdentifier from,
TableIdentifier to
amogh-jahagirdar commented on PR #11165:
URL: https://github.com/apache/iceberg/pull/11165#issuecomment-2366898231
Also double check spotless, seems like those checks are failing. You can run
`./gradlew :iceberg-aws:spotlessApply`.
Also cc @geruh @singhpk234 @rahil-c @jackye1995 in case
amogh-jahagirdar commented on code in PR #11165:
URL: https://github.com/apache/iceberg/pull/11165#discussion_r1770604602
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##
@@ -415,15 +415,19 @@ public void renameTable(TableIdentifier from,
TableIdentifier to
jishangarg commented on PR #11165:
URL: https://github.com/apache/iceberg/pull/11165#issuecomment-2359327812
Can somebody please review my PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jishangarg opened a new pull request, #11165:
URL: https://github.com/apache/iceberg/pull/11165
This PR addresses an issue in the AWS Glue renameTable method where an
incorrect exception is thrown when a table with the new name already exists.
According to the Iceberg Catalog interface, the
10 matches
Mail list logo
