Xuanwo commented on PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#issuecomment-2921004532
https://github.com/apache/iceberg-rust/pull/1369 has been merged, maybe we
can remove the callback now.
--
This is an automated message from the Apache Git Service.
To respond to th
Fokko commented on PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#issuecomment-2902572019
Thanks for chiming in here, I've created PR
https://github.com/apache/iceberg-rust/pull/1369 that implements #2. PTAL
--
This is an automated message from the Apache Git Service.
To
kevinjqliu commented on PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#issuecomment-2901908181
I like #2 as well. The refactor should be less effort than scaffolding
between python class and rust struct
--
This is an automated message from the Apache Git Service.
To respo
liurenjie1024 commented on PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#issuecomment-2900132681
> Thanks everyone for chiming in here. Let me summarize the discussion. I
think there is consensus that the callback is not ideal.
>
> 1. Supply required information to c
Fokko commented on PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#issuecomment-2893274391
Thanks everyone for chiming in here. Let me summarize the discussion. I
think there is consensus that the callback is not ideal.
1. Supply required information to construct the s
liurenjie1024 commented on PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#issuecomment-2889978156
> Our current design focuses solely on Rust users, but some users may simply
want to parse the file themselves and don’t want iceberg-rust to handle any
transformation (such as
liurenjie1024 commented on code in PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#discussion_r2094990362
##
bindings/python/src/manifest.rs:
##
@@ -0,0 +1,401 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
liurenjie1024 commented on code in PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#discussion_r2094987303
##
bindings/python/src/manifest.rs:
##
@@ -0,0 +1,420 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
liurenjie1024 commented on code in PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#discussion_r2094987303
##
bindings/python/src/manifest.rs:
##
@@ -0,0 +1,420 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
kevinjqliu commented on code in PR #1328:
URL: https://github.com/apache/iceberg-rust/pull/1328#discussion_r2094174778
##
bindings/python/src/manifest.rs:
##
@@ -0,0 +1,420 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreemen
10 matches
Mail list logo
