Re: [PR] Docs: Sync contributing page / refer to website for contributing [iceberg]

2024-02-26 Thread via GitHub
nastra merged PR #9776: URL: https://github.com/apache/iceberg/pull/9776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Docs: Sync contributing page / refer to website for contributing [iceberg]

2024-02-26 Thread via GitHub
nastra commented on PR #9776: URL: https://github.com/apache/iceberg/pull/9776#issuecomment-1963941126 thanks for reviewing @Fokko, I've applied your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Docs: Sync contributing page / refer to website for contributing [iceberg]

2024-02-26 Thread via GitHub
Fokko commented on code in PR #9776: URL: https://github.com/apache/iceberg/pull/9776#discussion_r1501571410 ## site/docs/contribute.md: ## @@ -145,6 +148,84 @@ Example: void sequenceNumber(long sequenceNumber); ``` +## Adding new functionality without breaking APIs +Ideal

Re: [PR] Docs: Sync contributing page / refer to website for contributing [iceberg]

2024-02-24 Thread via GitHub
Fokko commented on code in PR #9776: URL: https://github.com/apache/iceberg/pull/9776#discussion_r1501571410 ## site/docs/contribute.md: ## @@ -145,6 +148,84 @@ Example: void sequenceNumber(long sequenceNumber); ``` +## Adding new functionality without breaking APIs +Ideal

[PR] Docs: Sync contributing page / refer to website for contributing [iceberg]

2024-02-22 Thread via GitHub
nastra opened a new pull request, #9776: URL: https://github.com/apache/iceberg/pull/9776 We currently have two markdown files that aren't fully in-sync about how to contribute to Iceberg. The one is only in the source tree, but not referenced. The other is the one on the website. I've