Re: [PR] Docs: Point links in metrics-reporting.md to GitHub Java source [iceberg]

2024-06-04 Thread via GitHub
nastra merged PR #10397: URL: https://github.com/apache/iceberg/pull/10397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Docs: Point links in metrics-reporting.md to GitHub Java source [iceberg]

2024-06-01 Thread via GitHub
nastra commented on code in PR #10397: URL: https://github.com/apache/iceberg/pull/10397#discussion_r1623188031 ## core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java: ## @@ -26,6 +26,10 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +/** + * A {

Re: [PR] Docs: Point links in metrics-reporting.md to GitHub Java source [iceberg]

2024-06-01 Thread via GitHub
nastra commented on code in PR #10397: URL: https://github.com/apache/iceberg/pull/10397#discussion_r1623187528 ## core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java: ## @@ -26,7 +26,11 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -class RESTM

Re: [PR] Docs: Point links in metrics-reporting.md to GitHub Java source [iceberg]

2024-05-30 Thread via GitHub
manuzhang commented on code in PR #10397: URL: https://github.com/apache/iceberg/pull/10397#discussion_r1620844093 ## core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java: ## @@ -26,7 +26,11 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -class RE