Re: [PR] Docs: Fix missing semicolons in SQL snippets. [iceberg]

2023-10-10 Thread via GitHub
Priyansh121096 commented on PR #8748: URL: https://github.com/apache/iceberg/pull/8748#issuecomment-1756235225 Thanks @Fokko! This was my first contribution to apache/iceberg. Hope to make many more in the future. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Docs: Fix missing semicolons in SQL snippets. [iceberg]

2023-10-10 Thread via GitHub
Priyansh121096 commented on code in PR #8748: URL: https://github.com/apache/iceberg/pull/8748#discussion_r1353371980 ## docs/spark-getting-started.md: ## @@ -69,7 +69,7 @@ To create your first Iceberg table in Spark, use the `spark-sql` shell or `spark ```sql -- local is t

Re: [PR] Docs: Fix missing semicolons in SQL snippets. [iceberg]

2023-10-10 Thread via GitHub
Fokko merged PR #8748: URL: https://github.com/apache/iceberg/pull/8748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Docs: Fix missing semicolons in SQL snippets. [iceberg]

2023-10-10 Thread via GitHub
Fokko commented on PR #8748: URL: https://github.com/apache/iceberg/pull/8748#issuecomment-1755637911 Great work @Priyansh121096 If we find more we can create a new PR. (I also noticed that some blocks start with: ``` ```SQL ``` For consistency it would be nice to have everything

Re: [PR] Docs: Fix missing semicolons in SQL snippets. [iceberg]

2023-10-10 Thread via GitHub
Fokko commented on code in PR #8748: URL: https://github.com/apache/iceberg/pull/8748#discussion_r1352755607 ## docs/spark-getting-started.md: ## @@ -69,7 +69,7 @@ To create your first Iceberg table in Spark, use the `spark-sql` shell or `spark ```sql -- local is the path-b