Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-03 Thread via GitHub
nastra merged PR #10411: URL: https://github.com/apache/iceberg/pull/10411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-03 Thread via GitHub
nastra commented on PR #10411: URL: https://github.com/apache/iceberg/pull/10411#issuecomment-2146711969 thanks for taking care of this @manuzhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-03 Thread via GitHub
manuzhang commented on PR #10411: URL: https://github.com/apache/iceberg/pull/10411#issuecomment-2145501680 @nastra As @Fokko said, #9965 wan't merged in time for 1.5.x branch and this PR basically back-ports the patch (resolving minor conflicts). I've built site locally and manually checke

Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-03 Thread via GitHub
bitsondatadev commented on code in PR #10411: URL: https://github.com/apache/iceberg/pull/10411#discussion_r1624498796 ## 1.5.2/docs/configuration.md: ## @@ -133,7 +133,7 @@ Iceberg catalogs support using catalog properties to configure catalog behaviors | clients

Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-03 Thread via GitHub
Fokko commented on code in PR #10411: URL: https://github.com/apache/iceberg/pull/10411#discussion_r1624425581 ## 1.5.2/docs/configuration.md: ## @@ -133,7 +133,7 @@ Iceberg catalogs support using catalog properties to configure catalog behaviors | clients

Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-03 Thread via GitHub
nastra commented on PR #10411: URL: https://github.com/apache/iceberg/pull/10411#issuecomment-2145011308 @manuzhang did you run this locally and do the links across versions work now correctly? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10411: URL: https://github.com/apache/iceberg/pull/10411#discussion_r1624294761 ## 1.5.2/docs/configuration.md: ## @@ -133,7 +133,7 @@ Iceberg catalogs support using catalog properties to configure catalog behaviors | clients

Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-03 Thread via GitHub
manuzhang commented on PR #10411: URL: https://github.com/apache/iceberg/pull/10411#issuecomment-2144947788 @Fokko This PR is open against docs branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-03 Thread via GitHub
Fokko commented on PR #10411: URL: https://github.com/apache/iceberg/pull/10411#issuecomment-2144936472 @bitsondatadev After this PR we need to fix this in the [docs branch](https://github.com/apache/iceberg/tree/docs), right? -- This is an automated message from the Apache Git Service. T

Re: [PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-01 Thread via GitHub
bitsondatadev commented on PR #10411: URL: https://github.com/apache/iceberg/pull/10411#issuecomment-2143501272 @manuzhang have you tried running this locally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] Docs: Fix internal links in 1.5.x releases [iceberg]

2024-06-01 Thread via GitHub
manuzhang opened a new pull request, #10411: URL: https://github.com/apache/iceberg/pull/10411 This fixes #10409, #10249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To