Re: [PR] Docs: Enhance Spark pages [iceberg]

2024-03-18 Thread via GitHub
manuzhang commented on PR #9920: URL: https://github.com/apache/iceberg/pull/9920#issuecomment-2003111009 @Fokko is fixing it in https://github.com/apache/iceberg/pull/9965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Docs: Enhance Spark pages [iceberg]

2024-03-13 Thread via GitHub
nastra commented on PR #9920: URL: https://github.com/apache/iceberg/pull/9920#issuecomment-1993885092 I don't think we want to merge #9939 because it only fixes some links. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Docs: Enhance Spark pages [iceberg]

2024-03-13 Thread via GitHub
manuzhang commented on PR #9920: URL: https://github.com/apache/iceberg/pull/9920#issuecomment-1993781522 Yes, after merging in #9943 and #9939, I will submit a fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Docs: Enhance Spark pages [iceberg]

2024-03-13 Thread via GitHub
nastra commented on PR #9920: URL: https://github.com/apache/iceberg/pull/9920#issuecomment-1993710672 Can we just have one single PR to fix all the broken links for the current version of the docs (`main`)? We would then also have to fix broken links for 1.4.0 / 1.4.1 / 1.4.2 / 1.4.3 / 1.5

Re: [PR] Docs: Enhance Spark pages [iceberg]

2024-03-12 Thread via GitHub
manuzhang commented on PR #9920: URL: https://github.com/apache/iceberg/pull/9920#issuecomment-1992837667 @bitsondatadev @nastra There is already https://github.com/apache/iceberg/pull/9939 reverting some of the links. I can submit another PR fixing other link changes in the following

Re: [PR] Docs: Enhance Spark pages [iceberg]

2024-03-12 Thread via GitHub
bitsondatadev commented on PR #9920: URL: https://github.com/apache/iceberg/pull/9920#issuecomment-1992620793 ### Oops Apologies, as I asked this and accidentally made a review instead of posted a comment. I generally don't dislike GH's UI but that one has bitten me quite a few times

Re: [PR] Docs: Enhance Spark pages [iceberg]

2024-03-12 Thread via GitHub
nastra merged PR #9920: URL: https://github.com/apache/iceberg/pull/9920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Docs: Enhance Spark pages [iceberg]

2024-03-11 Thread via GitHub
nastra commented on PR #9920: URL: https://github.com/apache/iceberg/pull/9920#issuecomment-1987806754 @manuzhang have you verified that all links works by locally running the site as described [here](https://github.com/apache/iceberg/blob/main/site/README.md)? -- This is an automated me

[PR] Docs: Enhance Spark pages [iceberg]

2024-03-11 Thread via GitHub
manuzhang opened a new pull request, #9920: URL: https://github.com/apache/iceberg/pull/9920 1. Fix internal links 2. Move `Type Compatibility` section from spark-writes.md to spark-getting-started.md -- This is an automated message from the Apache Git Service. To respond to the messag