Re: [PR] Docs: Document accessing instance variables [iceberg]

2024-09-06 Thread via GitHub
aokolnychyi commented on PR #11087: URL: https://github.com/apache/iceberg/pull/11087#issuecomment-2335037486 Thanks for reviewing, @stevenzwu @manuzhang @jerqi! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Docs: Document accessing instance variables [iceberg]

2024-09-06 Thread via GitHub
aokolnychyi merged PR #11087: URL: https://github.com/apache/iceberg/pull/11087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Docs: Document accessing instance variables [iceberg]

2024-09-05 Thread via GitHub
aokolnychyi commented on code in PR #11087: URL: https://github.com/apache/iceberg/pull/11087#discussion_r1746503833 ## site/docs/contribute.md: ## @@ -388,6 +388,34 @@ When passing boolean arguments to existing or external methods, use inline comme dropTable(identifier, pur

Re: [PR] Docs: Document accessing instance variables [iceberg]

2024-09-05 Thread via GitHub
manuzhang commented on code in PR #11087: URL: https://github.com/apache/iceberg/pull/11087#discussion_r1746409783 ## site/docs/contribute.md: ## @@ -388,6 +388,34 @@ When passing boolean arguments to existing or external methods, use inline comme dropTable(identifier, purge

[PR] Docs: Document accessing instance variables [iceberg]

2024-09-05 Thread via GitHub
aokolnychyi opened a new pull request, #11087: URL: https://github.com/apache/iceberg/pull/11087 This PR documents our recommendations for accessing instance variables to improve consistency of the code. -- This is an automated message from the Apache Git Service. To respond to the messa