Re: [PR] Deprecate to_requested_schema [iceberg-python]

2024-07-12 Thread via GitHub
HonahX merged PR #918: URL: https://github.com/apache/iceberg-python/pull/918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Deprecate to_requested_schema [iceberg-python]

2024-07-12 Thread via GitHub
syun64 commented on PR #918: URL: https://github.com/apache/iceberg-python/pull/918#issuecomment-2225485718 > Do we want to delete the tests added in #910? We do have tests for internal functions, and I think the casting behavior of timestamps through `_to_requested_schema` is one tha

Re: [PR] Deprecate to_requested_schema [iceberg-python]

2024-07-12 Thread via GitHub
syun64 commented on PR #918: URL: https://github.com/apache/iceberg-python/pull/918#issuecomment-2225467379 > #910 Yeah good question - this is on our list of things to do before we hit 1.0.0 milestone: https://github.com/apache/iceberg-python/issues/334 > How about also adding

[PR] Deprecate to_requested_schema [iceberg-python]

2024-07-11 Thread via GitHub
syun64 opened a new pull request, #918: URL: https://github.com/apache/iceberg-python/pull/918 Following up on a discussion on: https://github.com/apache/iceberg-python/pull/910#discussion_r1674879351 - The intended usage of `to_requested_schema` is to support our internal functions