kevinjqliu commented on PR #1516:
URL: https://github.com/apache/iceberg-python/pull/1516#issuecomment-2755697692
except for the `MAX_JAVA_SIGNED` variable, everything else LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Fokko merged PR #1516:
URL: https://github.com/apache/iceberg-python/pull/1516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
Fokko commented on code in PR #1516:
URL: https://github.com/apache/iceberg-python/pull/1516#discussion_r2015012515
##
pyiceberg/table/puffin.py:
##
Review Comment:
Played around with some snippets, but I think I'll leave it as is now :)
--
This is an automated message
Fokko commented on code in PR #1516:
URL: https://github.com/apache/iceberg-python/pull/1516#discussion_r2014898543
##
pyiceberg/table/puffin.py:
##
Review Comment:
Thanks for sharing, that looks pretty neat
--
This is an automated message from the Apache Git Service.
T
kevinjqliu commented on code in PR #1516:
URL: https://github.com/apache/iceberg-python/pull/1516#discussion_r2001709586
##
pyiceberg/table/puffin.py:
##
Review Comment:
i found this gist for reading puffin files
https://gist.github.com/t04glovern/aec9e2391aa94eb017f1bc
