Re: [PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

2024-05-07 Thread via GitHub
hsiang-c closed pull request #10201: Data: Adopt EncryptingFileIO in Java read API URL: https://github.com/apache/iceberg/pull/10201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

2024-05-07 Thread via GitHub
hsiang-c commented on PR #10201: URL: https://github.com/apache/iceberg/pull/10201#issuecomment-2097719895 Spoke to Gidon offline and this PR is redundant in the latest design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

2024-05-07 Thread via GitHub
ggershinsky commented on code in PR #10201: URL: https://github.com/apache/iceberg/pull/10201#discussion_r1591933618 ## data/src/main/java/org/apache/iceberg/data/GenericReader.java: ## @@ -45,14 +45,14 @@ import org.apache.iceberg.util.PartitionUtil; class GenericReader imp

Re: [PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

2024-04-22 Thread via GitHub
hsiang-c commented on PR #10201: URL: https://github.com/apache/iceberg/pull/10201#issuecomment-2069698512 FYI @ggershinsky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

2024-04-22 Thread via GitHub
hsiang-c opened a new pull request, #10201: URL: https://github.com/apache/iceberg/pull/10201 ### Note to reviewers - One of our customers would like to read PME-encrypted tables in JVM application. - Therefore, switching to `EncryptingFileIO` as https://github.com/apache/iceberg/pu