aokolnychyi merged PR #9267:
URL: https://github.com/apache/iceberg/pull/9267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
aokolnychyi commented on PR #9267:
URL: https://github.com/apache/iceberg/pull/9267#issuecomment-1851600453
Thanks for reviewing, @szehon-ho!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
aokolnychyi commented on code in PR #9267:
URL: https://github.com/apache/iceberg/pull/9267#discussion_r1423696499
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java:
##
@@ -219,27 +219,27 @@ public void testPrimitiveColumns(
aokolnychyi commented on PR #9267:
URL: https://github.com/apache/iceberg/pull/9267#issuecomment-1851598973
@szehon-ho, I faced some test failures in other PRs because of issues in
`GenericFileAppenderFactory`. It was not that easy to fix that class so I went
ahead and added `GenericFileWri
szehon-ho commented on code in PR #9267:
URL: https://github.com/apache/iceberg/pull/9267#discussion_r1423408972
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java:
##
@@ -219,27 +219,27 @@ public void testPrimitiveColumns()
szehon-ho commented on code in PR #9267:
URL: https://github.com/apache/iceberg/pull/9267#discussion_r1423408972
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java:
##
@@ -219,27 +219,27 @@ public void testPrimitiveColumns()
aokolnychyi commented on code in PR #9267:
URL: https://github.com/apache/iceberg/pull/9267#discussion_r1422256919
##
data/src/test/java/org/apache/iceberg/io/TestFileWriterFactory.java:
##
@@ -76,18 +76,15 @@ public static Object[] parameters() {
private final FileFormat f
aokolnychyi commented on PR #9267:
URL: https://github.com/apache/iceberg/pull/9267#issuecomment-1849745072
@nastra @Fokko @flyrain @amogh-jahagirdar, could you check this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
aokolnychyi commented on code in PR #9267:
URL: https://github.com/apache/iceberg/pull/9267#discussion_r1422245545
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java:
##
@@ -219,27 +219,27 @@ public void testPrimitiveColumns(
aokolnychyi opened a new pull request, #9267:
URL: https://github.com/apache/iceberg/pull/9267
This PR adds `GenericFileWriterFactory`, similar to `FlinkFileWriterFactory`
and `SparkFileWriterFactory`. This is a new API that should be used in favor of
methods in `FileAppenderFactory` for cr
10 matches
Mail list logo
